-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: HMI Node #143
Merged
Merged
refactor: HMI Node #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmajek
commented
Aug 16, 2024
maciejmajek
force-pushed
the
refactor/hmi
branch
2 times, most recently
from
August 19, 2024 22:30
7a54871
to
e4d5f63
Compare
maciejmajek
force-pushed
the
refactor/hmi
branch
from
August 19, 2024 23:08
7d0dfb3
to
bbde65c
Compare
maciejmajek
force-pushed
the
chore/cleanup
branch
from
August 20, 2024 09:22
942d7e0
to
002b732
Compare
maciejmajek
force-pushed
the
refactor/hmi
branch
from
August 21, 2024 15:15
0a53419
to
0cc7263
Compare
maciejmajek
commented
Aug 21, 2024
maciejmajek
force-pushed
the
refactor/hmi
branch
2 times, most recently
from
August 27, 2024 12:57
43981d0
to
8e425e4
Compare
4 tasks
maciejmajek
force-pushed
the
refactor/hmi
branch
4 times, most recently
from
September 9, 2024 10:04
f2ffeea
to
f1ee683
Compare
boczekbartek
force-pushed
the
refactor/hmi
branch
from
September 17, 2024 10:44
6a5eb22
to
f84f3ec
Compare
…ies (text-to-text, speech-to-speech, etc.) feat: handle faiss index loading error feat: add to base hmi class feat: add basic tools to the base node feat: skeleton class for voice hmi feat: handle faiss initialization error, add robot_description_package param chore: add license to voice_hmi feat: implement voice_hmi agents
feat: skeleton handle_task_feedback_request implementation chore: remove deprecated Feedback.srv fix(state_based.py): add status field with value "error" to error log entries in ToolRunner class fix(action_handler_mixin.py): raise exception and log error if task action server is not available refactor(base.py): refactor BaseHMINode constructor to accept robot_description_package parameter and handle it accordingly
feat: enhance typing chore: cleanup feat: artifact store poc fix: add missing imports feat: use artifact database in text hmi chore: move rai navigator to nav2 specific tools chore: cleanup fix: include system prompt in text hmi fix: remove deprecated streamlit hmi, fix imports fix: display tool calls when ai_msg.content is not empty
Signed-off-by: Bartłomiej Boczek <[email protected]>
boczekbartek
force-pushed
the
refactor/hmi
branch
from
September 17, 2024 10:47
f84f3ec
to
fd23402
Compare
fix(voice_hmi): use HumanMessage instead of string fix(text_hmi): typo in import
rachwalk
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #149
Purpose
This PR introduces a
BaseHMINode
class to streamline the implementation of various Human-Machine Interface (HMI) modalities (e.g., text-to-text, speech-to-speech). The goal is to simplify the current HMI architecture, which has separate and complex solutions for different modalities.Proposed Changes
This PR:
BaseHMINode
. This base class provides core functionality for HMI nodes, including loading the system wide system prompt, querying a FAISS index, publishing processing statuses, and handling feedback requests.Issues
Related: #142
Testing
TODO