Modal loading indicator and close Modal event #1578
Conversation
azriel46d
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
|
|
|
Travis is failing on |
@azriel46d For the moment no need to do anything about this as it should be handled in another ready-to-merge PR. |
There was a problem hiding this comment.
Just a small suggestion and docu is not in sync. (lerna run docu should get automatically applied as pre-commit hook if you did a npm i in the luigi root folder initially).
And it would be great if you could adapt one of the e2e tests that open the modal, to also close it programmatically (could be as simple as calling win().LuigiClient.uxManager().closeModal() and expecting the modal to be closed afterwards.
You could take https://github.com/SAP/luigi/blob/master/test/e2e-test-application/e2e/tests/1-angular/microfrontends.spec.js#L27 and duplicate that one, already does everything except closing.
|
Test has been added accordingly. |
test/e2e-test-application/src/app/project/settings/settings.component.html
Outdated
Show resolved
Hide resolved
test/e2e-test-application/src/app/project/settings/settings.component.html
Outdated
Show resolved
Hide resolved
…mponent.html Co-authored-by: Ndricim Rrapi <[email protected]>
…mponent.html Co-authored-by: Ndricim Rrapi <[email protected]>
…dal-loading-indicator
There was a problem hiding this comment.
suggestion to fix failing e2e-test:
In : luigi-client-link-manager-features.spec#L256
Change .find('button') to .contains('Click here')
…nfig * master: Add up arrow key press to global search (SAP#1587) fix e2e test (SAP#1589) Update fiddle fd styles to 0.11.0 (SAP#1581) Modal loading indicator and close Modal event (SAP#1578) Integrate plugin readme in docu (SAP#1564) Luigi sample with Next.js (SAP#1579) Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
Description
Changes proposed in this pull request:
luigi.get-contextto check for auto hide,luigi.hide-loading-indicator,luigi.show-loading-indicatorto show and hide the loading respectively.luigi.close-modalwhich the Modal listens to.closeModalfunction inside the ux client module which fires the even in point 2.Related issue(s)