Luigi sample with NextJs #1579
Merged
Luigi sample with NextJs #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleychh
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr and
UlianaMunich
as code owners
|
|
maxmarkus
previously requested changes
Aug 24, 2020
UlianaMunich
suggested changes
Aug 24, 2020
There was a problem hiding this comment.
Have a couple of suggestions:
- Include Fundamental Styles and sap theming same as in other examples in package.jsonn
- re-use the same default page layout we use in other examples (then it will be easier for us to upgrade the version of FD Styles all at once for all examples)
UlianaMunich
suggested changes
Aug 24, 2020
|
@UlianaMunich , good catch. I made a mistake that Luigi core is not necessary to have fundamental styles, only micro frontend part needs. |
ndricimrr
requested changes
Aug 25, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Aug 31, 2020
…nfig * master: Add up arrow key press to global search (SAP#1587) fix e2e test (SAP#1589) Update fiddle fd styles to 0.11.0 (SAP#1581) Modal loading indicator and close Modal event (SAP#1578) Integrate plugin readme in docu (SAP#1564) Luigi sample with Next.js (SAP#1579) Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
Merged
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a sample code of Luigi is running on top of Next JS
Fixes #1122