Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add up arrow key press to global search #1587

Merged
merged 8 commits into from
Aug 31, 2020
Merged

Add up arrow key press to global search #1587

merged 8 commits into from
Aug 31, 2020
+49 −28

Conversation

stanleychh
Copy link
Contributor

@stanleychh stanleychh commented Aug 26, 2020 •
edited
Loading

Fixes #1577

Changes proposed in this pull request:

  1. add up arrow key event
  2. fix styling (padding) issue
  3. create a keycode.js file to manage keyboard events.

search

@stanleychh stanleychh added this to the Sprint 12 milestone Aug 26, 2020
@stanleychh stanleychh added the bug Something isn't working label Aug 26, 2020
@UlianaMunich UlianaMunich self-assigned this Aug 27, 2020
UlianaMunich
UlianaMunich approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndricimrr ndricimrr self-assigned this Aug 27, 2020
ndricimrr
ndricimrr approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@stanleychh stanleychh merged commit 89ebe70 into SAP:master Aug 31, 2020
@stanleychh stanleychh deleted the 1577-arrow-up-global-search branch August 31, 2020 09:21
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Aug 31, 2020
@JohannesDoberer
Merge branch 'master' into possibility-to-set-title-without-header-co…
fb50cdf 
…nfig

* master:
  Add up arrow key press to global search (SAP#1587)
  fix e2e test (SAP#1589)
  Update fiddle fd styles to 0.11.0 (SAP#1581)
  Modal loading indicator and close Modal event (SAP#1578)
  Integrate plugin readme in docu (SAP#1564)
  Luigi sample with Next.js (SAP#1579)
  Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
Merged
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Add up arrow key press to global search (SAP#1587)
c5e620a 
* add up arrow key event
* create a keycode.js file to manage keyboard events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

Assignees

@UlianaMunich UlianaMunich

@ndricimrr ndricimrr

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging this pull request may close these issues.

Add "Up" arrow key press to Global Search
4 participants
@stanleychh @UlianaMunich @ndricimrr @maxmarkus