Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom mf for user settings #1802

Merged
merged 42 commits into from
Jan 15, 2021
Merged

Custom mf for user settings #1802

merged 42 commits into from
Jan 15, 2021

Conversation

JohannesDoberer
Copy link
Contributor

Custom mf to manage user settings data
Fixes #1770

@JohannesDoberer
Profile setting dialog (SAP#1710)
adff27d
@JohannesDoberer
Merge branch 'master' into feature-user-settings
98d9f73 
* master:
  add blog post (SAP#1731)
  Release v1.6.0 (SAP#1729)
  cm fix (SAP#1727)
  Added state info to replacestate (SAP#1725)
  Simple storage api for micro frontends#1696 (SAP#1707)
  Fix broken angular link (SAP#1717)
  Fix css issue for Iframe (SAP#1716)
@JohannesDoberer
Read/write settings using core api (SAP#1709)
f13522f
@JohannesDoberer
Merge branch 'master' into feature-user-settings
b2f4026 
* master:
  update luigi in fiddle
  Change Search using Luigi.globalSearch() API (SAP#1690) (SAP#1734)
  Fix `withoutSync()` history behaviour (SAP#1720)
  Update index.scss
  Bump highlight.js in /core/examples/luigi-example-vue (SAP#1723)
@JohannesDoberer
Merge branch 'master' into feature-user-settings
fb7d89f 
* master:
  release-v1.7.0 (SAP#1759)
  CM fixes (SAP#1755)
  changes for night build (SAP#1757)
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (SAP#1751)
@JohannesDoberer
Dialog box for user settings (SAP#1750)
f653bb0 
known issue.. grid is not displayed correctly in ie11
@JohannesDoberer
Merge branch 'master' into feature-user-settings
c3c5f1f 
* master:
  Bump ini from 1.3.5 to 1.3.8 in /scripts (SAP#1783)
  Bump ini from 1.3.5 to 1.3.8 in /website/docs (SAP#1780)
  Bump ini from 1.3.5 to 1.3.7 in /client (SAP#1774)
  Bump ini from 1.3.5 to 1.3.7 in /core (SAP#1775)
  replace insensitive term (SAP#1771)
@JohannesDoberer
no message
b5ef797
@JohannesDoberer
iframe styling
cc7a50b
@JohannesDoberer
Merge branch 'master' into custom-mf-for-user-settings
09827b1 
* master:
  Release v1.7.1 (SAP#1793)
  Update example on luigi-core-api.md navigate() (SAP#1769)
  Reversed search for keepselected (SAP#1761)
  fiddle patch
  Browser history fix  (SAP#1784)
  Manage user settings (SAP#1789)
  Fix drawer undefined bug (SAP#1765)
  Fixing cypress tests for Angular Test Application (SAP#1730)
  Global search enhancements SAP#1738 (SAP#1753)

# Conflicts:
#	client/webpack.config.js
#	core/package.json
#	core/src/App.html
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	core/src/core-api/config.js
#	core/src/core-api/ux.js
#	core/src/utilities/constants.js
#	core/src/utilities/helpers/usersetting-dialog-helpers.js
#	docs/luigi-core-api.md
#	test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@JohannesDoberer
no message
91ede0c
@JohannesDoberer
no message
d075879
@JohannesDoberer
custom userSettings + test
1b6d84d
@JohannesDoberer
user settings docu
29a3f96
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Jan 8, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 15 milestone Jan 8, 2021
@JohannesDoberer
Copy link
Contributor Author

Custom mf to test

<!DOCTYPE html>
<html>

<head>
    <title></title>
    <meta name="viewport"
        content="width=device-width, user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1" />
   <link rel="stylesheet" type="text/css" href="index.css" media="screen" />
</head>

<body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <script src="node_modules/@luigi-project/client/luigi-client.js"></script>
    <script>

        let myUserSettings = {};
        window.LuigiClient.addInitListener((context, origin) => {
            console.log('init');
            renderData(context);
        });

        function renderData(context) {
            myUserSettings = context.userSettingsData;
            if (myUserSettings.theme) {
                let button = document.querySelector('.' + myUserSettings.theme);
                button.classList.add('active');
            }
        }

        function changeTheming(theme) {
            document.querySelectorAll('.btnList button').forEach(button => {
                button.classList.remove('active');
            });
            console.log('changeTheming');
            document.querySelector('.' + theme).classList.add('active');
            myUserSettings.theme = theme;
            window.LuigiClient.sendCustomMessage({ id: 'luigi.updateUserSettings', data: myUserSettings })
        }
    </script>
    <div>
        <ul class="btnList">
            <li>
                <button class="red" style="color:red" onclick="changeTheming('red')">Red</button>
            </li>
            <li>
                <button class="green" style="color: green" onclick="changeTheming('green')">Green</button>
            </li>
        </ul>
    </div>
</body>

</html>

@legteodav legteodav self-requested a review January 11, 2021 08:38
@legteodav legteodav self-assigned this Jan 11, 2021
legteodav
legteodav reviewed Jan 11, 2021
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
legteodav
legteodav reviewed Jan 11, 2021
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer marked this pull request as ready for review January 12, 2021 15:24
@stanleychh stanleychh self-assigned this Jan 13, 2021
@JohannesDoberer
Merge branch 'master' into custom-mf-for-user-settings
c2a438a 
* master:
  Make navigateIframe and prepareInternalData functions be async (SAP#1799)

# Conflicts:
#	core/src/App.html
@JohannesDoberer
no message
e97b60b
stanleychh
stanleychh reviewed Jan 13, 2021
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
stanleychh
stanleychh reviewed Jan 13, 2021
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
stanleychh
stanleychh reviewed Jan 13, 2021
View reviewed changes
core/src/App.html Show resolved Hide resolved
core/src/UserSettingsDialog.html Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
legteodav
legteodav approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@legteodav legteodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.... A lot of code to review :(

@JohannesDoberer JohannesDoberer merged commit a363f9a into SAP:master Jan 15, 2021
@JohannesDoberer JohannesDoberer deleted the custom-mf-for-user-settings branch January 15, 2021 15:05
legteodav pushed a commit to legteodav/luigi that referenced this pull request Jan 19, 2021
@JohannesDoberer @legteodav
Custom mf for user settings (SAP#1802)
15cbb4c
legteodav added a commit that referenced this pull request Jan 19, 2021
@legteodav @ndricimrr
@UlianaMunich @JohannesDoberer @alexandra-simeonova @hardl @stanleychh
Add fiddle example and docu for web components (#1795)
1fd217d 
* First commit for wc

* Adding example for WC

* Adding Web Component Documentation

* Doc changes

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Fixing error in luigi core doc

* Adding nv documentation

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Adding doc images

* Update docs/luigi-core-api.md

Co-authored-by: Uliana Caceres <[email protected]>

* Removed unused file

* Rename component title

* removed white spaces

* Adding clazz name to fiddle example, removign examples in the documentation

* adding new fiddle component

* Adding UI5 Component

* Changing label UI5 components

* Custom mf for user settings (#1802)

* Rewrite getting started guide (#1766)

* state-store fix (#1814)

Co-authored-by: Stanley Hsu <[email protected]>

* ng support lib enhancements (#1809)

Co-authored-by: JohannesDoberer <[email protected]>

* 1767 different visual appearances (#1790)

* Profile setting dialog (#1710)

* Read/write settings using core api (#1709)

* Dialog box for user settings (#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>

* merging and resolving conflics

* adding new fiddle component

* Adding UI5 Component

Co-authored-by: Ndricim Rrapi <[email protected]>
Co-authored-by: Uliana Caceres <[email protected]>
Co-authored-by: JohannesDoberer <[email protected]>
Co-authored-by: Aleksandra Simeonova <[email protected]>
Co-authored-by: Philipp Pracht <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>
@ndricimrr ndricimrr mentioned this pull request Jan 21, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Custom mf for user settings (SAP#1802)
e3bd758
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@legteodav @ndricimrr
@UlianaMunich @JohannesDoberer @alexandra-simeonova @hardl @stanleychh
Add fiddle example and docu for web components (SAP#1795)
6ff2858 
* First commit for wc

* Adding example for WC

* Adding Web Component Documentation

* Doc changes

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Fixing error in luigi core doc

* Adding nv documentation

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update docs/web-component.md

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Update website/fiddle/public/wc/luigiExampleWC.js

Co-authored-by: Ndricim Rrapi <[email protected]>

* Adding doc images

* Update docs/luigi-core-api.md

Co-authored-by: Uliana Caceres <[email protected]>

* Removed unused file

* Rename component title

* removed white spaces

* Adding clazz name to fiddle example, removign examples in the documentation

* adding new fiddle component

* Adding UI5 Component

* Changing label UI5 components

* Custom mf for user settings (SAP#1802)

* Rewrite getting started guide (SAP#1766)

* state-store fix (SAP#1814)

Co-authored-by: Stanley Hsu <[email protected]>

* ng support lib enhancements (SAP#1809)

Co-authored-by: JohannesDoberer <[email protected]>

* 1767 different visual appearances (SAP#1790)

* Profile setting dialog (SAP#1710)

* Read/write settings using core api (SAP#1709)

* Dialog box for user settings (SAP#1750)

known issue.. grid is not displayed correctly in ie11

* Adding new configuration for enum displayed as buttons

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Changing testdataid with id in html attribute

* Adding again testid

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* Update core/src/UserSettingsEditor.html

Co-authored-by: Stanley Hsu <[email protected]>

* changing button to segment and group....

* Fixing integration tests

Co-authored-by: JohannesDoberer <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>

* merging and resolving conflics

* adding new fiddle component

* Adding UI5 Component

Co-authored-by: Ndricim Rrapi <[email protected]>
Co-authored-by: Uliana Caceres <[email protected]>
Co-authored-by: JohannesDoberer <[email protected]>
Co-authored-by: Aleksandra Simeonova <[email protected]>
Co-authored-by: Philipp Pracht <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@legteodav legteodav legteodav approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@stanleychh stanleychh

@legteodav legteodav

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.

Custom usersettings micro frontends
3 participants
@JohannesDoberer @stanleychh @legteodav