Proposed 2.3.0-b2 #5086
Merged
Proposed 2.3.0-b2 #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixInnerObjTemplate2 amendment: Apply inner object templates to all remaining (non-AMM) inner objects. Adds a unit test for applying the template to sfMajorities. Other remaining inner objects showed no problems having templates applied. * Move CMake directory * Rearrange sources * Rewrite includes * Recompute loops --------- Co-authored-by: Pretty Printer <[email protected]>
* fix "account_nfts" with unassociated marker returning issue * create unit test for fixing nft page invalid marker not returning error add more test change test name create unit test * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * fix "account_nfts" with unassociated marker returning issue * [FOLD] accumulated review suggestions * move BEAST check out of lambda function --------- Authored-by: Scott Schurr <[email protected]>
This version includes fix codecov/codecov-action#1471 which should end the codecov upload errors due to throttling.
… the ledger. (XRPLF#4663) * Add feature / amendment "InvariantsV1_1" * Adds invariant AccountRootsDeletedClean: * Checks that a deleted account doesn't leave any directly accessible artifacts behind. * Always tests, but only changes the transaction result if featureInvariantsV1_1 is enabled. * Unit tests. * Resolves XRPLF#4638 * [FOLD] Review feedback from @gregtatcam: * Fix unused variable warning * Improve Invariant test const correctness * [FOLD] Review feedback from @mvadari: * Centralize the account keylet function list, and some optimization * [FOLD] Some structured binding doesn't work in clang * [FOLD] Review feedback 2 from @mvadari: * Clean up and clarify some comments. * [FOLD] Change InvariantsV1_1 to unsupported * Will allow multiple PRs to be merged over time using the same amendment. * fixup! [FOLD] Change InvariantsV1_1 to unsupported * [FOLD] Update and clarify some comments. No code changes. * Move CMake directory * Rearrange sources * Rewrite includes * Recompute loops * Fix merge issue and formatting --------- Co-authored-by: Pretty Printer <[email protected]>
…5049) * fix CTID in tx command returns invalidParams on lowercase hex * test mixed case and change auto to explicit type * add header cctype because std::tolower is called * remove unused local variable * change test case comment from 'lowercase' to 'mixed case' --------- Co-authored-by: Zack Brunson <[email protected]>
Signed-off-by: dashangcun <[email protected]> Co-authored-by: dashangcun <[email protected]> Co-authored-by: Zack Brunson <[email protected]>
* Make xrpld target optional * Add job to test Conan recipe * [fold] address review comments * [fold] Enable tests in workflows * [fold] Rename with_xrpld option * [fold] Fix grep expression
* Document the need to specify "xrpld" and "tests" to build and test rippled.
The names of the files should reflect the name of the Dir class. Co-authored-by: Zack Brunson <[email protected]> Co-authored-by: Ed Hennis <[email protected]>
* `account_objects` returns an invalid field error if `type` is not supported. This includes objects an account can't own, or which are unsupported by `account_objects` * Includes: * Amendments * Directory Node * Fee Settings * Ledger Hashes * Negative UNL
* Includes updated instructions in BUILD.md.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #5086 +/- ##
=========================================
+ Coverage 71.1% 71.4% +0.3%
=========================================
Files 796 796
Lines 66997 67073 +76
Branches 11005 10866 -139
=========================================
+ Hits 47639 47878 +239
+ Misses 19358 19195 -163
... and 1280 files with indirect coverage changes |
Bronek
approved these changes
Aug 1, 2024
intelliot
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
just for transparency - channeling internal signoffs:
- Proposed 2.3.0-b2 (e5aa605) 👍 on Windows.
- Linux, Debug build, all good (rippled synced, unit tests passing) (there are lots of flavours of Linux - this is Debian bookworm with gcc 13.3 and mold 2.32.1)
- Linux built clean, all unit tests passed.
- Proposed 2.3.0-b2 (e5aa605) is 👍 from Integration Tests
- MacOS 👍 - unit tests passing, rippled synced to mainnet. rippled version 2.3.0-b2+e5aa605742befe585309cb380796fa6d56bb6f04.DEBUG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a beta for the 2.3.0 release.
Highlights:
The base branch is
release. All releases (including betas) go inrelease. This PR will be merged with--ff-only(not squashed or rebased, and not using the GitHub UI) to bothreleaseanddevelop.Context of Change
This introduces
fixInnerObjTemplate2amendment to improve construction of inner ledger objects.InvariantsV1_1unsupported amendment to expand invariant checking. The amendment will be supported after more invariants are added.Type of Change
API Impact
No API impact.