Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end tests for multitoken transfers between different types of accounts #578

Closed
3 tasks
james-chf opened this issue Oct 11, 2022 · 2 comments
Closed
3 tasks

Comments

@james-chf
Copy link
Contributor

james-chf commented Oct 11, 2022

VPs which implement the multitoken interface (#482) must ensure they call the both the sender's and receiver's VPs when a transfer is made (e.g. #114). If the sender's VP is a "user VP" (i.e. vp_user-like), then the transfer should only be allowed if the sender has signed the transfer - this is how regular token transfers are authorized.

vp-user-like VPs are:

We should have tests against an example multitoken VP (e.g. the one from https://github.com/anoma/anoma-wasm-multitoken)

@james-chf james-chf changed the title vp_user should support multitoken transfers vp_user should support authorizing multitoken transfers Oct 11, 2022
@james-chf james-chf moved this to Todo in Namada-Old Oct 11, 2022
@james-chf james-chf self-assigned this Dec 8, 2022
@james-chf
Copy link
Contributor Author

james-chf commented Dec 12, 2022

vp_user-like VPs (e.g. vp_implicit, vp_validator) should be updated also

@james-chf james-chf moved this from Todo to WIP in Namada-Old Dec 12, 2022
@james-chf james-chf changed the title vp_user should support authorizing multitoken transfers User VPs should support authorizing multitoken transfers Dec 12, 2022
@james-chf james-chf changed the title User VPs should support authorizing multitoken transfers vp_user-like VPs should support authorizing multitoken transfers Dec 12, 2022
@james-chf james-chf moved this from WIP to Pending Devnet in Namada-Old Jan 9, 2023
@james-chf james-chf changed the title vp_user-like VPs should support authorizing multitoken transfers End-to-end tests for multitoken transfers between different types of accounts Jan 9, 2023
@james-chf
Copy link
Contributor Author

Rescoped this ticket as the transfer functionality was already implemented

@james-chf james-chf moved this from Pending Devnet to Tested in Devnet in Namada-Old Feb 8, 2023
@james-chf james-chf moved this from Tested in Devnet to Done (testnet) in Namada-Old Feb 8, 2023
@github-project-automation github-project-automation bot moved this from Done (testnet) to Tested in Devnet in Namada-Old Feb 8, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* feat: release changelog

* feat: add newline

* feat: changelog for types

* feat: release-it for root

* fix: bump dependencies versions correctly with jq

* feat: always bump packages

* fix: readVecU8Pointer import

* feat: package bumper in node

* feat: release it configs cjs

* docs: publish info

* feat: release scripts for all packages

* feat: release script for namada interface

* docs: more accurate tag info

* fix: missing comma in json after rebase

* fix: yarn.lock after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

1 participant