Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for multitoken transfers between implicit and established accounts #886

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Dec 12, 2022

Relates to #578

Depends on #894 which updates a test wasm which is used in these tests.

This PR adds test coverage for multitoken transfers between implicit and established accounts. Some more general helper functions have been added as part of this PR.

@james-chf james-chf force-pushed the james/mainline/vp-user-multitoken-auth branch 3 times, most recently from c6a7bd4 to 3e1e5c7 Compare December 13, 2022 13:04
@james-chf james-chf force-pushed the james/mainline/vp-user-multitoken-auth branch from 7ce82e1 to 3eef031 Compare December 14, 2022 16:34
@james-chf james-chf changed the base branch from main to james/mainline/tx-write-storage-key December 14, 2022 16:36
@james-chf james-chf changed the title Ensure vp_user-like VPs correctly authorize multitoken transfers Add e2e tests for multitoken transfers between implicit and established accounts Dec 16, 2022
@james-chf james-chf force-pushed the james/mainline/vp-user-multitoken-auth branch 2 times, most recently from 4e2839f to 0275204 Compare December 16, 2022 15:40
@james-chf james-chf marked this pull request as ready for review December 16, 2022 20:21
@james-chf james-chf changed the base branch from james/mainline/tx-write-storage-key to main December 16, 2022 20:22
@james-chf james-chf force-pushed the james/mainline/vp-user-multitoken-auth branch 4 times, most recently from 1288860 to f5ccdda Compare January 3, 2023 16:49
@juped juped added this to the 0.14 milestone Jan 10, 2023
@james-chf james-chf requested review from sug0 and batconjurer January 12, 2023 10:01
@james-chf james-chf changed the base branch from main to james/mainline/tx-write-storage-key January 12, 2023 10:01
@juped juped force-pushed the james/mainline/tx-write-storage-key branch from a3e50e7 to aee7ed3 Compare February 7, 2023 00:18
@juped juped force-pushed the james/mainline/vp-user-multitoken-auth branch from f5ccdda to f2d9eda Compare February 7, 2023 00:27
Base automatically changed from james/mainline/tx-write-storage-key to main February 7, 2023 01:49
@juped juped merged commit 94ebcef into main Feb 7, 2023
@juped juped deleted the james/mainline/vp-user-multitoken-auth branch February 7, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants