Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code to handle valid table creation and updates #13

Open
astrochun opened this issue Feb 1, 2020 · 5 comments
Open

Code to handle valid table creation and updates #13

astrochun opened this issue Feb 1, 2020 · 5 comments
Assignees
@astrochun
Labels
enhancement New feature or request

Comments

@astrochun
Copy link
Owner

Something consistent for both Zcalbase_gal and Evolution of Galaxies
@astrochun astrochun added the enhancement New feature or request label Feb 1, 2020
@astrochun astrochun self-assigned this Feb 1, 2020
@astrochun
Copy link
Owner Author

@Reagen and @cmccormick1: We should discuss how best to do this through Metallicity_Stack_Commons

cmccormick1 added a commit that referenced this issue Mar 15, 2020
@cmccormick1
(Issue #13) Added bin info table to get N_stack values. Got rid of qu…
a9d828e 
…ality assurance function.
@astrochun astrochun mentioned this issue Mar 19, 2020
Merged
cmccormick1 added a commit that referenced this issue Mar 26, 2020
@cmccormick1
(Issue #13) Changed EW from 2Ang to 1.6Ang.
5d1db9b
astrochun added a commit that referenced this issue Mar 26, 2020
@astrochun
Write revised valid table in valid_table.make_validation_table; Updat…
13bfb91 
…e column_names to include bin_valid_rev in filenames_dict (iss #13, #25)
astrochun added a commit that referenced this issue Mar 26, 2020
@astrochun
valid_table: PEP8 fixes and documentation (#13)
a564367
@astrochun
Copy link
Owner Author

Need to change compare_by_eye to use revised validation table instead of specifying in codes.

astrochun added a commit that referenced this issue Apr 13, 2020
@astrochun
valid_table: Use relative import for column_names (iss #13)
ccc9ad2
@astrochun
Copy link
Owner Author

Additional commits in: 4f3d677, 2002763

Also pulled develop and release/0.8.0 for consistency: 3e85dc7, 0988ee3

@astrochun
Copy link
Owner Author

astrochun commented Apr 13, 2020 •
edited
Loading

For next release, we will need to fix compare_by_eye to use a table instead of defining each available sample via a set of np.where, which is currently done.

Update: Decided that it would be best in the current situation to implement in a new feature/validation_tables2 branch. Release 0.9.0 will be the default.

astrochun added a commit that referenced this issue Apr 13, 2020
@astrochun
valid_table: remove dependence on exists for now (iss #13)
2b6436e
@astrochun astrochun mentioned this issue Apr 13, 2020
Merged
astrochun added a commit that referenced this issue Jun 4, 2020
@astrochun
column_names: Fix bin_valid_rev definition (iss #13)
bd91d19
astrochun added a commit that referenced this issue Jun 4, 2020
@astrochun
valid_table: Use os.path.join (iss #13)
9362e4b
@astrochun
Copy link
Owner Author

See ea4f63b and f12fd68.

To handle manual override, I created feature/validation_tables2 branch

@astrochun astrochun mentioned this issue Jun 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astrochun