Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique identifying column names for properties #25

Closed
astrochun opened this issue Feb 19, 2020 · 3 comments
Closed

Unique identifying column names for properties #25

astrochun opened this issue Feb 19, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request organization Simplify with imports, remove extraneous stuff

Comments

@astrochun
Copy link
Owner

astrochun commented Feb 19, 2020

Overview/Motivation

Due to a mismatch of array/column names, it has become prudent that these names should be defined to avoid confusion. This issue will track such changes both in this code and changes reflected in Zcalbase_gal and Evolution-of-Galaxies.

There are a few common names that we will use:

  1. A set of bin columns (e.g., bin_ID, N_stack, and Detection) [37a6c75]
  2. A set for stellar mass and/or SFR binning (e.g., logM_min, logM_max, logM_avg, logM_median) [cde2a20, b04a93a, 16acb11]
  3. A set for R23 and/or O32 binning (e.g., logR23_min, logR23_max, logR23_avg, logR23_median) [c174f21, b04a93a]
  4. A set of columns for individual galaxies (e.g., ID, logR23, logO32, two_beta, three_beta) [064e69c, 4c9e940]
  5. A set of columns containing Gaussian fitting results (e.g., [LINE]_Flux_Observed, etc.) [9a858dc]
    Note: Need to include stellar absorption results. Done here: ad0b5fd
  6. A set of columns for composite line ratios (e.g., logR23_composite, two_beta_composite) [170ead8]
  7. A set of dust attenuations columns (e.g., E(B-V), Hg/Hb, Hd/Hb) [24003ea]

Functions to enable easier use:

  1. A function to merge an undefined number of lists using *args (merge_column_names) [e9af9d8]
  2. A function to remove entries from a list (remove_from_list) [311ab05, 14a79fd]

Defined filenames:

  1. A dictionary object called filename_dict
    See: 1ecaf7a, c4fc361, b0540bf, 23fed9d, ba79f41, 8a3f8f5, 0320c9a, 746f037, b1c1b86

    • bin_info.tbl: bin_ID, N_stack, avg/min/max/median of bin property
      [bin_names0, bin_mzevolve_names0 or bin_zcalbase_names0]

    • bin_validation.tbl: bin_ID, Detection, N_stack, OIII4363_values [bin_names0 + extra]

    • bin_emission_line_fit.tbl: bin_ID, [LINE]_Properties [bin_ID + gauss_names0]

    • bin_emission_line_fit.revised.tbl: Same as above

    • bin_derived_properties.tbl: bin_ID, logR23_composite, logO32_composite, two_beta_composite, three_beta_composite, T_e, 12+log(O/H), log(O+/H), log(O++/H), O+/H, O++/H [bin_ID, bin_ratios0, temp_metal_names0]

    • bin_derived_properties.revised.tbl: Same as above

    • individual_properties.tbl: Includes ID, logR23/logO32 or logM/logLHb, emission-line information [indv_names0, gauss_names0]

    • individual_bin_info.tbl: Includes bin_ID, ID, avg/min/max/median of bin property [bin_names0, bin_mzevolve_names0 or bin_zcalbase_names0, ID]

    • individual_derived_properties.tbl: Includes ID, logR23, logO32, two_beta, three_beta, T_e, 12+log(O/H), log(O+/H), log(O++/H), O+/H, O++/H [indv_names0, temp_metal_names0]

    • composite_spectra.fits: 1D spectra composite spectra combined into a 2-D array and provided with a proper FITS header [f4a290e]

Implementation within Metallicity Stack Commons code:

  1. Change analysis.composite_indv_det (see feature/composite_indv_det to use bin_ID (835f4b7), [LINE]_Flux_Observed (9a858dc), T_e and 12+log(O/H) (50a28df)
  2. Change analysis.composite_indv_det to use the same filename convention
@astrochun astrochun added enhancement New feature or request organization Simplify with imports, remove extraneous stuff labels Feb 19, 2020
@astrochun astrochun self-assigned this Feb 19, 2020
@astrochun
Copy link
Owner Author

New issue for adoption in MSC: @Reagen and @cmccormick1

astrochun added a commit that referenced this issue Feb 19, 2020
@astrochun astrochun changed the title Unique identifying columns for properties Unique identifying column names for properties Feb 19, 2020
astrochun added a commit that referenced this issue Feb 19, 2020
astrochun added a commit that referenced this issue Feb 20, 2020
astrochun added a commit that referenced this issue Feb 20, 2020
@astrochun
Copy link
Owner Author

Merged into master

astrochun added a commit that referenced this issue Mar 5, 2020
@astrochun astrochun reopened this Mar 5, 2020
astrochun added a commit that referenced this issue Mar 15, 2020
@astrochun astrochun mentioned this issue Mar 15, 2020
@astrochun astrochun mentioned this issue Mar 18, 2020
astrochun added a commit that referenced this issue Mar 26, 2020
…e column_names to include bin_valid_rev in filenames_dict (iss #13, #25)
@astrochun
Copy link
Owner Author

Closing issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request organization Simplify with imports, remove extraneous stuff
Projects
None yet
Development

No branches or pull requests

1 participant