feat: visionOS support #3058
Merged
feat: visionOS support #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
force-pushed
the
visionos-staging
branch
from
99ee863 to
9838fb3
Compare
13 tasks
royjit
approved these changes
Jun 29, 2023
| @@ -16,7 +16,7 @@ import Amplify | |||
| public class AmplifyAWSServiceConfiguration { | |||
|
|
|||
| /// - Tag: AmplifyAWSServiceConfiguration.amplifyVersion | |||
| public static let amplifyVersion = "2.12.0" | |||
| public static let amplifyVersion = "visionos-preview" | |||
There was a problem hiding this comment.
no need of a number? something like visionos-preview-0.0.1, will be useful in keeping track of bug fixes.
There was a problem hiding this comment.
Good call. Addressed in e5e51ed.
royjit
approved these changes
Jun 29, 2023
atierian
added a commit
that referenced
this pull request
Oct 23, 2023
atierian
added a commit
that referenced
this pull request
Nov 8, 2023
atierian
added a commit
that referenced
this pull request
Nov 9, 2023
harsh62
pushed a commit
that referenced
this pull request
Feb 14, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 14, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 15, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 15, 2024
sebaland
pushed a commit
that referenced
this pull request
Feb 21, 2024
sebaland
pushed a commit
that referenced
this pull request
Feb 22, 2024
sebaland
pushed a commit
that referenced
this pull request
Feb 23, 2024
sebaland
pushed a commit
that referenced
this pull request
Feb 26, 2024
sebaland
pushed a commit
that referenced
this pull request
May 1, 2024
harsh62
pushed a commit
that referenced
this pull request
Oct 17, 2024
harsh62
added a commit
that referenced
this pull request
Oct 21, 2024
* feat: visionOS support (#3058) * fix readme typo and make instructions clearer (#3070) * fix: update xrOS --> visionOS in os directive checks * chore(build): fix integration tests * fix: Fixing Analytics, Storage and Predictions integration tests * fix: Fixing Push Notification tests. Also reverting some scheme changes. * chore: Updating README * chore: update ReadMe me to remove visionos-preview branch * chore: add visionOS to build and unit test jobs (#3900) * Update Amplify/Core/Configuration/Internal/Amplify+Reset.swift Co-authored-by: Sebastian Villena <[email protected]> * worked on review comments * fixed unit tests * remove the platform checks --------- Co-authored-by: Ian Saultz <[email protected]> Co-authored-by: Abhash Kumar Singh <[email protected]> Co-authored-by: Sebastian Villena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds preview support for visionOS.
Important Note: As with macOS, visionOS appears to require apps add the Keychain Sharing entitlement and a keychain group for keychain access.
Changes
#if os(xrOS)checks to:DeviceInforeturns.zeroforscreenBoundsbecauseUIScreenisn't availableUIScreenrelated. I'd imagine we can get this working because it's only used in a single spot. Disabling it on visionOS for now.os(xrOS)is now foreground.visionos-previewKnown Issues
Some CoreML APIs have different behavior on visionOS. This only affects you if you're using the CoreMLPredictionsPlugin standalone or explicitly setting
.offlineonly for requests through the AWSPredictionsPlugin.UI tests appear to work on visionOS with some limitations. This affects our PushNotifications integration tests because they're set up as UI test cases. Problematic test cases were manually tested to verify expected behavior.
CI/CD
Integration Test Results
Analytics
API
Auth
DataStore
Geo
Predictions
PushNotifications
Storage
General Checklist
Added new tests to cover change, if neededNew or updated tests includeGiven When Theninline code documentation and are named accordinglytestThing_condition_expectation()If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.