-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix readme typo and make instructions clearer [skip ci] #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisabhash
approved these changes
Jul 11, 2023
atierian
added a commit
that referenced
this pull request
Oct 23, 2023
atierian
added a commit
that referenced
this pull request
Nov 8, 2023
atierian
added a commit
that referenced
this pull request
Nov 9, 2023
harsh62
pushed a commit
that referenced
this pull request
Feb 14, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 14, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 15, 2024
thisisabhash
pushed a commit
that referenced
this pull request
Feb 15, 2024
ruisebas
pushed a commit
that referenced
this pull request
Feb 21, 2024
ruisebas
pushed a commit
that referenced
this pull request
Feb 22, 2024
ruisebas
pushed a commit
that referenced
this pull request
Feb 23, 2024
ruisebas
pushed a commit
that referenced
this pull request
Feb 26, 2024
ruisebas
pushed a commit
that referenced
this pull request
May 1, 2024
MuniekMg
pushed a commit
to MuniekMg/amplify-swift
that referenced
this pull request
May 17, 2024
(cherry picked from commit 9a12d2b)
harsh62
pushed a commit
that referenced
this pull request
Oct 17, 2024
harsh62
added a commit
that referenced
this pull request
Oct 21, 2024
* feat: visionOS support (#3058) * fix readme typo and make instructions clearer (#3070) * fix: update xrOS --> visionOS in os directive checks * chore(build): fix integration tests * fix: Fixing Analytics, Storage and Predictions integration tests * fix: Fixing Push Notification tests. Also reverting some scheme changes. * chore: Updating README * chore: update ReadMe me to remove visionos-preview branch * chore: add visionOS to build and unit test jobs (#3900) * Update Amplify/Core/Configuration/Internal/Amplify+Reset.swift Co-authored-by: Sebastian Villena <[email protected]> * worked on review comments * fixed unit tests * remove the platform checks --------- Co-authored-by: Ian Saultz <[email protected]> Co-authored-by: Abhash Kumar Singh <[email protected]> Co-authored-by: Sebastian Villena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix branch name typo in README.
General Checklist
Added new tests to cover change, if neededBuild succeeds with all target using Swift Package ManagerAll unit tests passAll integration tests passDocumentation update for the change if requiredNew or updated tests includeGiven When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.