Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix readme typo and make instructions clearer [skip ci] #3070

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

atierian
Copy link
Member

Description

Fix branch name typo in README.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian requested a review from a team as a code owner June 30, 2023 13:32
@atierian atierian merged commit c423912 into visionos-preview Oct 11, 2023
@atierian atierian deleted the chore/visionos-readme branch October 11, 2023 19:59
MuniekMg pushed a commit to MuniekMg/amplify-swift that referenced this pull request May 17, 2024
harsh62 added a commit that referenced this pull request Oct 21, 2024
* feat: visionOS support (#3058)

* fix readme typo and make instructions clearer (#3070)

* fix: update xrOS --> visionOS in os directive checks

* chore(build): fix integration tests

* fix: Fixing Analytics, Storage and Predictions integration tests

* fix: Fixing Push Notification tests. Also reverting some scheme changes.

* chore: Updating README

* chore: update ReadMe me to remove visionos-preview branch

* chore: add visionOS to build and unit test jobs (#3900)

* Update Amplify/Core/Configuration/Internal/Amplify+Reset.swift

Co-authored-by: Sebastian Villena <[email protected]>

* worked on review comments

* fixed unit tests

* remove the platform checks

---------

Co-authored-by: Ian Saultz <[email protected]>
Co-authored-by: Abhash Kumar Singh <[email protected]>
Co-authored-by: Sebastian Villena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants