Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gmsa linux support #3464

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

saikiranakula-amzn
Copy link
Contributor

@saikiranakula-amzn saikiranakula-amzn commented Nov 4, 2022

Summary

gMSA support on linux (AL2022)

Implementation details

This is a feature branch merge
(https://github.com/aws/amazon-ecs-agent/tree/feature/gmsa-linux-support)
Original feature branch(For reference)
(https://github.com/aws/amazon-ecs-agent/tree/feature/gmsa-support-on-linux)

PRs:
#3439 - vendor changes
#3445 - capability advertisement gMSA on linux
#3448 - common function windows/linux gMSA
#3452 - agent changes to support gMSA linux

Testing

New tests cover the changes:

Description for the changelog

ECS Agent changes to support gMSA support for Linux feature.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

saikiranakula-amzn and others added 4 commits November 4, 2022 00:10
*changes to ecs-init to establish communication of agent with
credentials-fetcher daemon
*changes to agent to advertise gMSA capability on Linux
@saikiranakula-amzn saikiranakula-amzn requested a review from a team as a code owner November 4, 2022 00:37
Copy link
Member

@fierlion fierlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging feature branch to dev

@singholt
Copy link
Contributor

singholt commented Nov 4, 2022

can you add a changelog description in PR details above?

@fierlion
Copy link
Member

fierlion commented Nov 4, 2022

can you add a changelog description in PR details above?

#3427 <- an example

@fierlion fierlion merged commit 85e598c into aws:dev Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants