Make event cache size based #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce a random processing queue split policy for testing purpose * Refactor existing split policy implementation * Add lookAheadFunc to stuckTaskSplitPolicy so that timer queue can control the new queue's maxLevel.
meiliang86
reviewed
May 29, 2020
| @@ -131,14 +136,28 @@ func New(maxSize int, opts *Options) Cache { | |||
| opts = &Options{} | |||
| } | |||
|
|
|||
| return &lru{ | |||
| cache := &lru{ | |||
There was a problem hiding this comment.
To me, size and count is either/or, meaning that if it's size based, we don't care about the count, as long as it stays within size limit.
There was a problem hiding this comment.
Agree, if maxSize is provided then it is size based only and count based otherwise. And if size based, lets still check for an upper limit for count to prevent the infinite growing, for safety sake.
yycptt
reviewed
May 29, 2020
vancexu
reviewed
May 30, 2020
meiliang86
approved these changes
Jun 1, 2020
yycptt
approved these changes
Jun 1, 2020
This was
linked to
issues
Jun 5, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
* Make event cache size based
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Make event cache size based
Why?
events part of #2350
How did you test it?
performance tests
Potential risks
history events related API latency