PR File Patch / Varoius Bug Fixes #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Goggins <[email protected]>
scipy 1.13.0 breaks a lot of stuff
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Markus Hauru <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Fix Facade Task Signature to Take `repo_git` instead of `repo_id`
Signed-off-by: Andrew Brain <[email protected]>
Rollback transaction when query throws exception
Signed-off-by: Gary White Jr <[email protected]>
Signed-off-by: Gary White Jr <[email protected]>
add podman compose file
handle rate limiting and more repo load messages
Fix some typos and broken links in the docs
added `sudo apt-get install libpq-dev` as it wasn't installed by default on a new instance Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Add full collection for messages
```bash
Traceback (most recent call last):
File "/home/ubuntu/github/virtualenvs/hosted/lib/python3.11/site-packages/celery/app/trace.py", line 451, in trace_task
R = retval = fun(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^
File "/home/ubuntu/github/virtualenvs/hosted/lib/python3.11/site-packages/celery/app/trace.py", line 734, in __protected_call__
return self.run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ubuntu/github/augur/augur/tasks/github/pull_requests/files_model/tasks.py", line 18, in process_pull_request_files
pull_request_files_model(repo.repo_id, logger, augur_db, manifest.key_auth)
File "/home/ubuntu/github/augur/augur/tasks/github/pull_requests/files_model/core.py", line 68, in pull_request_files_model
pr_file_rows += [{
^^
File "/home/ubuntu/github/augur/augur/tasks/github/pull_requests/files_model/core.py", line 68, in <listcomp>
pr_file_rows += [{
^^
File "/home/ubuntu/github/augur/augur/tasks/github/util/gh_graphql_entities.py", line 344, in __iter__
coreData['totalCount']
~~~~~~~~^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
```
```python
if coreData is not None:
self.logger.info(f"... core data obtained")
else:
self.logger.info(f"Helen, the ghost in our machine, did not get a numerical result for core data (value): {data} \n Zero value assigned.")
coreData['totalCount'] = 0
except KeyError as e:
self.logger.error("Could not extract paginate result because there was no data returned")
self.logger.error(
''.join(traceback.format_exception(None, e, e.__traceback__)))
self.logger.info(f"Graphql paramters: {params}")
return
```
```python
try:
if coreData is not None:
if coreData.get('totalCount') is not None:
self.logger.info("... core data obtained")
else:
self.logger.info(f"Helen, the ghost in our machine, did not get a numerical result for core data (value): {data} \n Zero value assigned.")
coreData['totalCount'] = 0
else:
self.logger.error("Core data is None, cannot proceed with operations on it.")
except KeyError as e:
self.logger.error("Could not extract paginate result because there was no data returned")
self.logger.error(''.join(traceback.format_exception(None, e, e.__traceback__)))
```
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Sean P. Goggins <[email protected]>
ABrain7710
previously approved these changes
May 13, 2024
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
sgoggins
added
deployed version
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
IsaacMilarky
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this patch is primarily to reduce the number of errors associated with pull request file retrieval on GitHub. A number of specific errors are corrected as indicated by the extensive commit comments in this PR.
Yes, I signed my commits.