Lineage pull request for: skeleton #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back due to issues with switching to v5.
Update `pre-commit` Hooks
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <[email protected]>
…re-commit_version Update the `ansible-lint` Version in the pre-commit Configuration
This will configure `dependabot` to scan Terraform configurations if they exist in a repository. If a repository stores a Terraform configuration in a sub- directory this configuration will need to be modified or an additional configuration must be added if there still exists a Terraform configuration in the root directory.
…uration_for_terraform Add `dependabot` Configuration for Terraform
Change from using an environment variable to the outputs of the cisagov/setup-env-github-action instead.
We use a `PACKER_VERSION` environment variable for the "Install Packer" step that is populated from the `setup-env` outputs to get around `yamllint` lint length limits.
We change the "Install shfmt" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
We change the "Install Terraform-docs" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store the Go version that is installed. This mirrors changes made to the other program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
cisagovbot
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
cisagovbot
added
the
upstream update
|
@mcdonnnj - I can take a look at these failures if you want. |
The `lint` job now requires the Ansible roles required for this project to be installed due to using the (new to us) v5 of `ansible-lint`
Update the dependabot configuration to index the two directories that have Terraform code in our Packer projects.
Update the `test` job to use the outputs of the cisagov/setup-env-github-action Action to mirror the changes made to the `lint` job.
Update the `build` job to use the outputs of the cisagov/setup-env-github-action Action to mirror the changes made to the `lint` job.
Update the `prerelease` workflow to use the outputs of the cisagov/setup-env-github-action Action to mirror changes made to the `build` workflow.
Update the `release` workflow to use the outputs of the cisagov/setup-env-github-action Action to mirror changes made to the `build` workflow.
Ah, sorry. I figured I knew what was wrong when I initially looked at the PR earlier, so I ended up resolving it before I saw your comment. Let me know if you think there's a better/more preferable way. |
dav3r
approved these changes
Oct 20, 2021
No worries. I wasn't sure what was wrong, so I was just offering to help if you were also on the high seas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-generic.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage