Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRMQTTServer: Fix bug when receiving an A/C message and not re-transmitting it. #1038

Merged
merged 11 commits into from
Feb 6, 2020
Merged

IRMQTTServer: Fix bug when receiving an A/C message and not re-transmitting it. #1038

merged 11 commits into from
Feb 6, 2020

Conversation

crankyoldgit
Copy link
Owner

  • When an incoming IR A/C message changed the state, we didn't always update the "previous" state once it was dealt with.
  • Misc. code style & typo fixes.
  • Version bump.
  • Extra unit tests used along the way.

Fixes #1035

@crankyoldgit
Tests to help debug Daikin2 power toggle issue
7de4902 
* Unit tests to try to duplicate a reported issue in IRMQTTServer (not 
yet found)
* Fix a typo

For #1035
@crankyoldgit
Add extra debugging messages.
e717c5f 
Ref #1035
@crankyoldgit
Enforce logic parsing order & more debug
6a60306 
For #1035
FYI @sheppy99
@crankyoldgit
Add more debugging code.
b81203a 
For #1035
@crankyoldgit
Separate out the MQTT_CLIMATE_HA_MODE stuff a bit
54f028a 
Make it easier to read and clearer.
For #1035
@sheppy99
@crankyoldgit
Ensure the previous A/C state gets updated.
13441dd 
* Fix an issue where in some cases the previous state wasn't getting
updated.
  - Add `markAsSent()` to `IRac` class.
* Fix some code indenting.

For #1035 @sheppy99
@crankyoldgit
Revert "Separate out the MQTT_CLIMATE_HA_MODE stuff a bit"
2b442b0 
This reverts commit 54f028a.
@crankyoldgit
Revert "Add more debugging code."
0a8844d 
This reverts commit b81203a.
@crankyoldgit
Revert "Enforce logic parsing order & more debug"
d41d969 
This reverts commit 6a60306.
@crankyoldgit
Revert "Add extra debugging messages."
68b0278 
This reverts commit e717c5f.
@crankyoldgit
Update version number.
c1149e8
@crankyoldgit crankyoldgit self-assigned this Feb 2, 2020
@sheppy99 sheppy99 mentioned this pull request Feb 3, 2020
Closed
@crankyoldgit crankyoldgit merged commit 0fc8379 into master Feb 6, 2020
@crankyoldgit crankyoldgit deleted the Issue1035 branch February 12, 2020 04:17
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
@crankyoldgit
v2.7.4 release
cc99d08 
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
@crankyoldgit crankyoldgit mentioned this pull request Feb 26, 2020
Merged
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
@crankyoldgit
v2.7.4 release (#1054)
eabfdd6 
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@jamsinclair jamsinclair Awaiting requested review from jamsinclair

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Power Stat doesn't reflect received command, JSON does
1 participant
@crankyoldgit