Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung AC Display and VirusDoctor toggles #1048

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

rg2k
Copy link
Contributor

@rg2k rg2k commented Feb 11, 2020

  1. Adds the capability to turn on/off the AC display. Useful if you sleep with the AC on.
  2. Adds the capability to turn on/off the VirusDoctor feature.

VirusDoctor generates active hydrogen and oxygen ion, which forms Hydroperoxy radicals (HOO–). It reacts with virus and turns into harmless water vapor (H2O) Also the active hydrogen (H) combines with OH-radical and forms water vapor, neutralizing harmful OH-radical.

Tested on Samsung AC model: AR09FSSDAWKNFA with remote: DB63-03556X003.

@crankyoldgit crankyoldgit self-requested a review February 12, 2020 03:46
@crankyoldgit crankyoldgit self-assigned this Feb 12, 2020
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this addition!
Mostly okay. Just some library-isms & code style/re-use things to correct.
Sorry for the nitpicks! :-)

src/ir_Samsung.h Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
src/ir_Samsung.h Outdated Show resolved Hide resolved
src/ir_Samsung.h Outdated Show resolved Hide resolved
src/ir_Samsung.h Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
@rg2k
Copy link
Contributor Author

rg2k commented Feb 12, 2020

Thanks a lot for this addition!
Mostly okay. Just some library-isms & code style/re-use things to correct.
Sorry for the nitpicks! :-)

Thanks for the nitpicks and apologies for being such a noob. Will get it sorted.

rg2k and others added 4 commits February 13, 2020 17:37
src/ir_Samsung.h:67:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/ir_Samsung.h:68:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/ir_Samsung.h:112:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Looks fine now. Just fixing some linter issues and we are good to go!

@crankyoldgit crankyoldgit merged commit b9fccef into crankyoldgit:master Feb 13, 2020
crankyoldgit added a commit that referenced this pull request Feb 13, 2020
* Add full support for Light (Display) & Ion (VirusDoctor) for Samsung 
A/Cs
* Adjust unit tests accordingly.
* Add unit tests for Light & Ion respectively.
* Update common A/C api

Fixes #1045
Ref: #1048

FYI @rg2k
@crankyoldgit
Copy link
Owner

Xref: #1045

crankyoldgit added a commit that referenced this pull request Feb 14, 2020
* Add full support for Light (Display) & Ion (VirusDoctor) for Samsung 
A/Cs
* Adjust unit tests accordingly.
* Add unit tests for Light & Ion respectively.
* Update common A/C api

Fixes #1045
Ref: #1048

FYI @rg2k
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
@crankyoldgit crankyoldgit mentioned this pull request Feb 26, 2020
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
@crankyoldgit
Copy link
Owner

The changes mentioned above have been included in the latest IRremoteESP8266 v2.7.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants