Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOTO: An experimental _(s)wipe_ at support for Toto Toilets. #1811

Merged
merged 5 commits into from
May 24, 2022
Merged

TOTO: An experimental _(s)wipe_ at support for Toto Toilets. #1811

merged 5 commits into from
May 24, 2022

Conversation

crankyoldgit
Copy link
Owner

  • Add sendToto() and decodeToto() routines.

    • Supports two (2) bit sizes, 24 (short) & 48 (long) bit codes.
    • Includes/assumes a standard bit prefix to ensure it fits into a uint64_t.
    • Xor integrity check.
    • LSBF order based on user analysis.

  • Update supported devices.

  • Add unit tests to cover new changes.

Legs crossed, this should do it for the Number Two toilet protocol supported by this library.
Roll on the next one.

Fixes #1806

@crankyoldgit
TOTO: An experimental (s)wipe at support for Toto Toilets.
1d1981f 
* Add `sendToto()` and `decodeToto()` routines.
  - Note: They only support the short/simple messages at present.
  - Codes produced from this may change. This is NOT final in any way.
* Update supported devices.
* Add unit tests to cover new changes.

This is primarily hobbled together to collect data to see if we can reduce the size of this protocol (in bits).
It won't decode the different "second" code in the longer messages yet.

For #1806
@crankyoldgit
Hopefully fix linter issue.
8be4c8d
@crankyoldgit
Work in Progress: Toto improvements.
a77b6c1 
* Shrink messages down to 24 bits, by expecting a 15 bit prefix. (0x2008)
* Experimental support for sending longer codes.
  - e.g. `sendToto(0x006060001010, kTotoLongBits);  // Oscillate Bidet`
* Refactor sending to include prefix.
* Refactor decoding to expect a prefix.
* Prep work for decoding Long messages (not ready yet)

For #1806
@crankyoldgit
Toto: Bit order swap & finish support for long codes
5a4db02 
* Change bit order to LSB per #1806 (comment)
* Finish adding support for long (48bit) codes.
* Update unit tests accordingly.
  - Add tests for long (48 bit) codes.

Fingers crossed, this should do it.
Fixes #1806
@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels May 22, 2022
@crankyoldgit crankyoldgit requested a review from NiKiZe May 22, 2022 01:28
@crankyoldgit crankyoldgit self-assigned this May 22, 2022
@crankyoldgit crankyoldgit mentioned this pull request May 22, 2022
Closed
NiKiZe
NiKiZe approved these changes May 22, 2022
View reviewed changes
src/IRremoteESP8266.h Outdated Show resolved Hide resolved
@crankyoldgit crankyoldgit merged commit 0f94857 into master May 24, 2022
@crankyoldgit crankyoldgit deleted the toto_toilet branch May 25, 2022 05:12
crankyoldgit added a commit that referenced this pull request Sep 15, 2022
@crankyoldgit
v2.8.3 release
ac3c15b 
_v2.8.3 (20220915)_

**[Bug Fixes]**
- Fix `#if` for DECODE_COOLIX48 (#1796)
- Add missing `prev`s to `decodeToState()` (#1783)

**[Features]**
- Add `pause()` function to ESP32 when receiving. (#1871)
- ARGO: Argo add `sendSensorTemp()` (#1858 #1859)
- HAIER_AC160: Experimental detail support. (#1852 #1804)
- BOSCH144: Add IRac class support (#1841)
- Mitsubishi_AC: update left vane in `IRac` class (#1837)
- Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829)
- Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826)
- GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821)
- Experimental basic support for Bosch 144bit protocol. (#1822 #1787)
- Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810)
- Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812)
- TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806)
- CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797)
- HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804)
- DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802)
- FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780)
- FUJITSU: Improve handling of short (command only) messages. (#1784 #1780)

**[Misc]**
- Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870)
- SONY: Update supported devices. (#1872)
- SAMSUNG: Update supported devices (#1873)
- NEC: Update supported devices (#1874)
- Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851)
- Inhibit protocol names for not-included protocols (#1853 #1851)
- Test out codeql static analysis (#1842)
- Remove pylint disable=no-self-use (#1817)
- Fujitsu General: update supported devices (#1813)
- DAIKIN: Update supported devices (#1808 #1807)
- Fujitsu: Update supported remote info. (#1801 #1794)
- DAIKIN128: Update supported devices (#1754)
- Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238)
- Daikin128: Additional unit test. (#1795 #1754)
- MIDEA: Update supported devices (#1791 #1790)
@crankyoldgit crankyoldgit mentioned this pull request Sep 15, 2022
Merged
crankyoldgit added a commit that referenced this pull request Sep 16, 2022
@crankyoldgit
v2.8.3 release (#1878)
84f596e 
**_v2.8.3 (20220915)_**

**[Bug Fixes]**
- Fix `#if` for DECODE_COOLIX48 (#1796)
- Add missing `prev`s to `decodeToState()` (#1783)

**[Features]**
- Add `pause()` function to ESP32 when receiving. (#1871)
- ARGO: Argo add `sendSensorTemp()` (#1858 #1859)
- HAIER_AC160: Experimental detail support. (#1852 #1804)
- BOSCH144: Add IRac class support (#1841)
- Mitsubishi_AC: update left vane in `IRac` class (#1837)
- Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829)
- Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826)
- GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821)
- Experimental basic support for Bosch 144bit protocol. (#1822 #1787)
- Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810)
- Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812)
- TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806)
- CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797)
- HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804)
- DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802)
- FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780)
- FUJITSU: Improve handling of short (command only) messages. (#1784 #1780)

**[Misc]**
- Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870)
- SONY: Update supported devices. (#1872)
- SAMSUNG: Update supported devices (#1873)
- NEC: Update supported devices (#1874)
- Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851)
- Inhibit protocol names for not-included protocols (#1853 #1851)
- Test out codeql static analysis (#1842)
- Remove pylint disable=no-self-use (#1817)
- Fujitsu General: update supported devices (#1813)
- DAIKIN: Update supported devices (#1808 #1807)
- Fujitsu: Update supported remote info. (#1801 #1794)
- DAIKIN128: Update supported devices (#1754)
- Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238)
- Daikin128: Additional unit test. (#1795 #1754)
- MIDEA: Update supported devices (#1791 #1790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamsinclair jamsinclair jamsinclair approved these changes

@NiKiZe NiKiZe NiKiZe approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Pending Confirmation Waiting for confirmation from user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Janitor support needed to unclog another Toilet protocol 🪠
3 participants
@crankyoldgit @NiKiZe @jamsinclair