BOSCH144: Add IRac class support #1841

NicoThien · 2022-07-18T18:18:36Z

BOSCH144: Add IRac class support
Power, Mode, Temp, Fan, Quiet is working
I want to add: SwingV, Turbo, Clean, Beep/LED (all separate 96-bit messages)

BOSCH144: Add IRac class support Power, Mode, Temp, Fan, Quiet is working I want to add: SwingV, Turbo, Clean, Beep/LED (all separate 96-bit messages)

NicoThien · 2022-07-18T18:48:50Z

Bosch CL3000i-Set 26 E Remote: RG10A(G2S)BGEF
#1787 (comment)

correction of a copy/paste error

crankyoldgit

Top effort adding the detailed protocol decode. That's an excellent start!

src/IRac.cpp

src/ir_Bosch.cpp

src/ir_Bosch.h

src/ir_Bosch.cpp

src/ir_Bosch.h

src/ir_Bosch.cpp

NicoThien · 2022-07-19T14:07:18Z

I will try to fix the errors.

Edit coding layout style

add getMode() and grtFan()

crankyoldgit · 2022-07-20T03:49:36Z

FYI, you'll also need to update the unit tests for this protocol, now that it has detailed support mostly.
eg.
https://github.com/crankyoldgit/IRremoteESP8266/runs/7417257804?check_suite_focus=true#step:6:2292

powerFlag is now set to "true" in the "state reset".

crankyoldgit

Looking much better. Nearly there!

crankyoldgit · 2022-07-22T00:39:11Z

src/ir_Bosch.cpp

@@ -8,9 +8,11 @@
 //   Brand: Bosch,  Model: RG10A(G2S)BGEF remote


Now that you've got a ir_Bosch.h file, and the "Supports" data is listed in that, you will need to remove the "Supports" comment section from the .cpp file. Otherwise it will fail one of our automated checks.
i.e. "Supports" info always goes into the .h file if it exists, if not, then into the .cpp file.

Also, please add yourself to the Copyright section. You've added significant work too. ;-)

crankyoldgit · 2022-07-22T00:40:38Z

src/ir_Bosch.cpp

-#ifndef ARDUINO
+/*#ifndef ARDUINO
 #include <string>
-#endif
+#endif*/
+#include <cstring>
+#include "ir_Bosch.h"


Why are these changes needed?

Without <cstring> I get std::memcpy(_.raw, new_code, kBosch144StateLength); the error message "std has no member memcpy". I thought <cstring> would replace <string>.
My programming skills are very limited.
My English too.

<cstring> is fine, e.g.:

IRremoteESP8266/src/ir_Samsung.cpp

Lines 14 to 17 in 85d587f

#include <cstring>

#ifndef ARDUINO

#include <string>

#endif

it was the other bit I was refering to. i.e. the removal of the #ifndef etc.

src/ir_Bosch.cpp

src/ir_Bosch.h

src/ir_Bosch.cpp

- commented out lines removed - change setInvertBytes() & setCheckSumS3() to private:

- add copyright - simplify getMode() & getFan() - initial temperature in getTemp() 25

removed // Supports: // Brand: Bosch, Model: CL3000i-Set 26 E A/C // Brand: Bosch, Model: RG10A(G2S)BGEF remote

crankyoldgit · 2022-08-04T23:22:33Z

Friendly ping. How it going?

NicoThien · 2022-08-05T12:37:49Z

If there are no other change requests...
It works for me.

src/ir_Bosch.cpp

_v2.8.3 (20220915)_ **[Bug Fixes]** - Fix `#if` for DECODE_COOLIX48 (#1796) - Add missing `prev`s to `decodeToState()` (#1783) **[Features]** - Add `pause()` function to ESP32 when receiving. (#1871) - ARGO: Argo add `sendSensorTemp()` (#1858 #1859) - HAIER_AC160: Experimental detail support. (#1852 #1804) - BOSCH144: Add IRac class support (#1841) - Mitsubishi_AC: update left vane in `IRac` class (#1837) - Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829) - Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826) - GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821) - Experimental basic support for Bosch 144bit protocol. (#1822 #1787) - Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810) - Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812) - TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806) - CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797) - HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804) - DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802) - FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780) - FUJITSU: Improve handling of short (command only) messages. (#1784 #1780) **[Misc]** - Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870) - SONY: Update supported devices. (#1872) - SAMSUNG: Update supported devices (#1873) - NEC: Update supported devices (#1874) - Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851) - Inhibit protocol names for not-included protocols (#1853 #1851) - Test out codeql static analysis (#1842) - Remove pylint disable=no-self-use (#1817) - Fujitsu General: update supported devices (#1813) - DAIKIN: Update supported devices (#1808 #1807) - Fujitsu: Update supported remote info. (#1801 #1794) - DAIKIN128: Update supported devices (#1754) - Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238) - Daikin128: Additional unit test. (#1795 #1754) - MIDEA: Update supported devices (#1791 #1790)

**_v2.8.3 (20220915)_** **[Bug Fixes]** - Fix `#if` for DECODE_COOLIX48 (#1796) - Add missing `prev`s to `decodeToState()` (#1783) **[Features]** - Add `pause()` function to ESP32 when receiving. (#1871) - ARGO: Argo add `sendSensorTemp()` (#1858 #1859) - HAIER_AC160: Experimental detail support. (#1852 #1804) - BOSCH144: Add IRac class support (#1841) - Mitsubishi_AC: update left vane in `IRac` class (#1837) - Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829) - Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826) - GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821) - Experimental basic support for Bosch 144bit protocol. (#1822 #1787) - Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810) - Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812) - TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806) - CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797) - HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804) - DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802) - FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780) - FUJITSU: Improve handling of short (command only) messages. (#1784 #1780) **[Misc]** - Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870) - SONY: Update supported devices. (#1872) - SAMSUNG: Update supported devices (#1873) - NEC: Update supported devices (#1874) - Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851) - Inhibit protocol names for not-included protocols (#1853 #1851) - Test out codeql static analysis (#1842) - Remove pylint disable=no-self-use (#1817) - Fujitsu General: update supported devices (#1813) - DAIKIN: Update supported devices (#1808 #1807) - Fujitsu: Update supported remote info. (#1801 #1794) - DAIKIN128: Update supported devices (#1754) - Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238) - Daikin128: Additional unit test. (#1795 #1754) - MIDEA: Update supported devices (#1791 #1790)

crankyoldgit · 2022-09-16T00:27:01Z

FYI, the changes mentioned above have now been included in the new v2.8.3 release of the library.

BOSCH144: Add IRac class support

db02a5c

BOSCH144: Add IRac class support Power, Mode, Temp, Fan, Quiet is working I want to add: SwingV, Turbo, Clean, Beep/LED (all separate 96-bit messages)

Update IRac.cpp

407f445

correction of a copy/paste error

NicoThien closed this Jul 19, 2022

crankyoldgit requested changes Jul 19, 2022

View reviewed changes

crankyoldgit self-assigned this Jul 19, 2022

crankyoldgit added the enhancement label Jul 19, 2022

NicoThien reopened this Jul 19, 2022

NicoThien added 3 commits July 19, 2022 16:19

Update IRac.cpp

b352e91

Edit coding layout style

Update ir_Bosch.h

b53f9d0

Edit coding layout style

Update ir_Bosch.h

392dcec

Edit coding layout style

NicoThien marked this pull request as draft July 19, 2022 15:47

NicoThien added 9 commits July 19, 2022 17:54

Update and rename src/ir_Bosch.h to Quelle/ir_Bosch.h

7d0aee5

Edit coding layout style

Rename Quelle/ir_Bosch.h to src/ir_Bosch.h

c42af88

Update ir_Bosch.cpp

25504b0

Edit coding layout style

Update ir_Bosch.cpp

3f9976b

Edit coding layout style

Update ir_Bosch.cpp

7e68176

Edit coding layout style

Update ir_Bosch.cpp

b2be8e0

Edit coding layout style

Update ir_Bosch.cpp

63ba1f2

Update ir_Bosch.cpp

23799e9

add getMode() and grtFan()

Update ir_Bosch.cpp

cfe77e2

NicoThien added 7 commits July 20, 2022 16:15

Update ir_Bosch.cpp

871eaf0

powerFlag is now set to "true" in the "state reset".

Update ir_Bosch_test.cpp

4850d29

Update ir_Bosch_test.cpp

bf8a63f

Update ir_Bosch_test.cpp

600ee91

Update ir_Bosch_test.cpp

b613652

Edit Test

cd1b9e7

Add files via upload

a190b3c

NicoThien added 3 commits July 21, 2022 20:45

Add files via upload

a8a8d52

Add files via upload

6bd484f

Update ir_Bosch.cpp

cc16b0c

crankyoldgit requested changes Jul 22, 2022

View reviewed changes

NicoThien added 3 commits July 22, 2022 15:13

Update ir_Bosch.h

edbfb61

- commented out lines removed - change setInvertBytes() & setCheckSumS3() to private:

Update ir_Bosch.cpp

b5696c8

- add copyright - simplify getMode() & getFan() - initial temperature in getTemp() 25

Update ir_Bosch.cpp

8b945ce

removed // Supports: // Brand: Bosch, Model: CL3000i-Set 26 E A/C // Brand: Bosch, Model: RG10A(G2S)BGEF remote

NicoThien added 2 commits August 5, 2022 12:02

Update src/ir_Bosch.cpp

c9dde47

Update ir_Bosch.cpp

f052cdb

NicoThien requested a review from crankyoldgit August 5, 2022 12:38

NicoThien marked this pull request as ready for review August 5, 2022 12:41

crankyoldgit requested changes Aug 7, 2022

View reviewed changes

src/ir_Bosch.cpp Outdated Show resolved Hide resolved

NicoThien added 3 commits August 8, 2022 19:25

Add files via upload

768aa33

Update ir_Bosch.cpp

ebac3f7

Update ir_Bosch.h

5a6db72

crankyoldgit approved these changes Aug 11, 2022

View reviewed changes

crankyoldgit merged commit 376fde2 into crankyoldgit:master Aug 11, 2022

crankyoldgit mentioned this pull request Sep 15, 2022

v2.8.3 release #1878

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BOSCH144: Add IRac class support #1841

BOSCH144: Add IRac class support #1841

NicoThien commented Jul 18, 2022

NicoThien commented Jul 18, 2022

crankyoldgit left a comment

NicoThien commented Jul 19, 2022

crankyoldgit commented Jul 20, 2022

crankyoldgit left a comment

crankyoldgit Jul 22, 2022

crankyoldgit Jul 22, 2022

crankyoldgit Jul 22, 2022

NicoThien Jul 22, 2022

crankyoldgit Jul 22, 2022

NicoThien Jul 22, 2022

crankyoldgit commented Aug 4, 2022

NicoThien commented Aug 5, 2022

crankyoldgit commented Sep 16, 2022

		@@ -8,9 +8,11 @@
		// Brand: Bosch, Model: RG10A(G2S)BGEF remote

BOSCH144: Add IRac class support #1841

BOSCH144: Add IRac class support #1841

Conversation

NicoThien commented Jul 18, 2022

NicoThien commented Jul 18, 2022

crankyoldgit left a comment

Choose a reason for hiding this comment

NicoThien commented Jul 19, 2022

crankyoldgit commented Jul 20, 2022

crankyoldgit left a comment

Choose a reason for hiding this comment

crankyoldgit Jul 22, 2022

Choose a reason for hiding this comment

crankyoldgit Jul 22, 2022

Choose a reason for hiding this comment

crankyoldgit Jul 22, 2022

Choose a reason for hiding this comment

NicoThien Jul 22, 2022

Choose a reason for hiding this comment

crankyoldgit Jul 22, 2022

Choose a reason for hiding this comment

NicoThien Jul 22, 2022

Choose a reason for hiding this comment

crankyoldgit commented Aug 4, 2022

NicoThien commented Aug 5, 2022

crankyoldgit commented Sep 16, 2022