Update IRac.cpp to also control left vane of Mitsubishi AC when command sent from generic IRac

[tpanajott]

Mitsubishi AC, when sent from generic IRac only controls the right vane. Make the left vane use the same setting.

[crankyoldgit]

Thanks for the PR.
I think the reason I had previously left it out was because not all Mitsubishi models have a "left vane", and I wasn't sure how they would react to that setting being set if they didn't have that feature.

I think I'll try to dig up some previous owners to see what happens if a single vane model gets controls for twin vane ones.

This change may also require some changes to the unit tests. i.e. Different than expected messages will be generated.

[tpanajott]

Sounds reasonable. I unfortunately only have a unit with two vanes to test with. If this is the case with other HVACs as well, maybe adding a flag for the generic IRac to treat them the same may be an option?

The only reason this is a problem for me is that I've made a custom PCB that I want to be able to handle many different HVACs and this project is perfect for that. But, the project is made around the use of the IRac so that it doesn't need specific code for each AC-unit.

[crankyoldgit]

Fingers crossed we will find out that "less featured" models just ignore the extra setting. That would be best.
Other than that, I'll look at adding "Model" support to the protocol to allow some models to support it, and some to ignore it.
I'm not against addressing the issue, just trying to find the best/safest way.

[tpanajott]

Sounds good, please tell if there's anything I can do to help and I'll see what I can do.

[crankyoldgit]

@nao-pon @ratnick @chaisaeng @jenish-jain @sheppy99 @mihalski

Hey Folks, you seem to have access to a Mitsubishi A/C based on previous issues logged with this library.
Can I get some of you to please test this branch (https://github.com/tpanajott/IRremoteESP8266/tree/patch-1) to see how a "single" vertical vane model reacts when it is also sent commands for a left vertical vane as well.

You'll need to use the IRac interface (IRMQTTServer or Tasmota, or EasyESP etc) or use setVaneLeft() explicitly,

If I get some "it works as expected"'s then I'll merge this PR in.

[nao-pon]

Hi! long time no see!

I tried a single vane model (MLZ-RX5017AS) with this PR code. It worked fine without any problems.

• Tasmota 12.0.2.3 + This PR's custom code
• MQTT Topic: "cmnd/tasmota_livingac/irhvac"
• JSON: "SwingV": "off", "SwingV": "auto", "SwingV": "highest", "SwingV": "high", "SwingV": "middle", "SwingV": "low" and "SwingV": "lowest" are OK!

{
    "StateMode": "SendStore",
    "Vendor": "MITSUBISHI_AC",
    "Model": "-1",
    "Power": "on",
    "Mode": "cool",
    "Celsius": "on",
    "Temp": 28,
    "FanSpeed": "auto",
    "SwingV": "lowest",
    "SwingH": "off",
    "Quiet": "off",
    "Turbo": "off",
    "Econo": "off",
    "Light": "off",
    "Filter": "off",
    "Clean": "off",
    "Beep": "off",
    "Sleep": -1
}

[crankyoldgit]

I tried a single vane model (MLZ-RX5017AS) with this PR code. It worked fine without any problems.

That's great news. Thanks for confirming.

[crankyoldgit]

I'm happy with this now.

[crankyoldgit]

FYI, the changes mentioned above have now been included in the new v2.8.3 release of the library.