Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_analyse_raw_data.py improvements #906

Merged
merged 2 commits into from
Sep 11, 2019
Merged

auto_analyse_raw_data.py improvements #906

merged 2 commits into from
Sep 11, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Add option to add a protocol name to constants & functions.
  • use kDefaultMessageGap instead of 100000
  • Update unit tests accordingly.

For #900

@crankyoldgit
auto_analyse_raw_data.py improvements
814b767 
* Add option to add a protocol name to constants & functions.
* use kDefaultMessageGap instead of 100000
* Update unit tests accordingly.

For #900
@crankyoldgit crankyoldgit self-assigned this Sep 11, 2019
@crankyoldgit
Add documentation link.
c0c15a7 
* Add link to documentation on how to include this in the library.

For #900
sillyfrog
sillyfrog approved these changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@sillyfrog sillyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, less manual boiler plate.

A thought (you know how I like to talk about ideas :) ): If targeting more recent Python versions (>3.6), you could also use f-strings: https://realpython.com/python-f-strings/#f-strings-a-new-and-improved-way-to-format-strings-in-python
But that would require users to have a recent Python install (which may or may not be an issue).

@crankyoldgit
Copy link
Owner Author

Today I learned about f-strings! Nice!

@crankyoldgit crankyoldgit merged commit 7f4e0d6 into master Sep 11, 2019
@crankyoldgit crankyoldgit deleted the Issue900 branch September 13, 2019 14:24
crankyoldgit added a commit that referenced this pull request Sep 23, 2019
@crankyoldgit
v2.6.6 release
9ca04ad 
_v2.6.6 (20190923)_

**[Bug Fixes]**
- Ensure `begin()` is called for every supported common a/c. (#905, #899)
- IRMQTTServer: Fix JSON state parsing. (#896)
- IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893)

**[Features]**
- Mitsubishi136: Full A/C support. (#898, #890)
- Fujitsu: Add support for ARRY4 remote. (#895)
- Web-AC-control: Add new WebUI example sketch. (#880, #886)
- Improve Common A/C API (#913)
- IRMQTTServer: Support for multiple climates. (#903)
- IRMQTTServer: Add TX channel support for HTTP interface. (#929)
- IRMQTTServer: Add option to clear retained settings. (#917)
- auto_analyse_raw_data.py: Add decode code generation. (#909)
- auto_analyse_raw_data.py: General improvements (#906)

**[Misc]**
- IRMQTTServer: Use latest API for common A/C. (#928)
- IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919)
- IRMQTTServer: Move from ArduinoJson v5 to v6. (#878)
- IRMQTTServer: Use retain for discovery message. (#881)
- Goodweather: Adjust timings & minor fixes. (#924)
- PanasonicAc: Add better SwingV support for common a/c framework. (#923)
- Daikin2: Corrections for common A/C interface. (#910)
- MitsubishiAC: Improve decoding. (#914)
- Fujitsu: Disable horiz swing for ARRY4. (#907)
- SamsungAc: Only send power on/off code if it's needed. (#884)
- Teco: Add timer support. (#883)
- More consistent A/C `::toString()` output. (#920)
@crankyoldgit crankyoldgit mentioned this pull request Sep 23, 2019
Merged
crankyoldgit added a commit that referenced this pull request Sep 23, 2019
@crankyoldgit
v2.6.6 release (#930)
b95793c 
_v2.6.6 (20190923)_

**[Bug Fixes]**
- Ensure `begin()` is called for every supported common a/c. (#905, #899)
- IRMQTTServer: Fix JSON state parsing. (#896)
- IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893)

**[Features]**
- Mitsubishi136: Full A/C support. (#898, #890)
- Fujitsu: Add support for ARRY4 remote. (#895)
- Web-AC-control: Add new WebUI example sketch. (#880, #886)
- Improve Common A/C API (#913)
- IRMQTTServer: Support for multiple climates. (#903)
- IRMQTTServer: Add TX channel support for HTTP interface. (#929)
- IRMQTTServer: Add option to clear retained settings. (#917)
- auto_analyse_raw_data.py: Add decode code generation. (#909)
- auto_analyse_raw_data.py: General improvements (#906)

**[Misc]**
- IRMQTTServer: Use latest API for common A/C. (#928)
- IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919)
- IRMQTTServer: Move from ArduinoJson v5 to v6. (#878)
- IRMQTTServer: Use retain for discovery message. (#881)
- Goodweather: Adjust timings & minor fixes. (#924)
- PanasonicAc: Add better SwingV support for common a/c framework. (#923)
- Daikin2: Corrections for common A/C interface. (#910)
- MitsubishiAC: Improve decoding. (#914)
- Fujitsu: Disable horiz swing for ARRY4. (#907)
- SamsungAc: Only send power on/off code if it's needed. (#884)
- Teco: Add timer support. (#883)
- More consistent A/C `::toString()` output. (#920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog sillyfrog approved these changes

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @sillyfrog