-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRMQTTServer: Add TX channel support for HTTP interface. #929
Conversation
* Allow "channel" (KEY_CHANNEL) argument to control which TX channel to send to. * Update "aircon" html page to be able to selection which climate channel to use. * Consolidate some duplicate code into `genStatTopic()` * Update comments/documentation on for full multi-channel TX support. * Fix some potential unreferenced pointer issues.
FYI @sheppy99 |
I just tried to compile it and it failed at 1131:18 which is
The changes I've made to IRMQTTServer.h are:
|
\o/ for @sheppy99 for finding this before it got merged.
@sheppy99 Thanks for finding that issue. Fix has been push to the branch. Please download and try it again! :) |
It compiles now although it does show 2 minor errors, the first one is expected with debug disabled, is the second one relevant?
|
Technically, they are compiler warnings, not errors. Just pushed another update to fix the latter warning. Let me know how that goes. The code should function the same. |
It compiles fine and its passed a quick ON and OFF test on ac_3, ac_4 and ac_5 from both the examples page and also from MQTT. Once I realised that I had to click the change button next to the channel before the channel change took effect. |
Excellent. Also pushed a change to try to fix the "debug" compiler warning too. Doesn't come up on my system, even before the change, but let me know if it fixes it too. |
Oh, and thanks for confirming it works as expected. |
The compiler warning has gone, apart from something to do with an unused variable in PUBSUBClient which doesn't break anything and has been there for a long time. I just tested 2 AC's this time and they turn ON and OFF from both the webpage and via MQTT. I also confirmed the Daikin2 on Channel 0 turns ON and OFF via MQTT with the full hex string |
Yep, that's an issue in their library. Nothing I can do about that one. Thanks for the confirmation that it's working as expected. |
_v2.6.6 (20190923)_ **[Bug Fixes]** - Ensure `begin()` is called for every supported common a/c. (#905, #899) - IRMQTTServer: Fix JSON state parsing. (#896) - IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893) **[Features]** - Mitsubishi136: Full A/C support. (#898, #890) - Fujitsu: Add support for ARRY4 remote. (#895) - Web-AC-control: Add new WebUI example sketch. (#880, #886) - Improve Common A/C API (#913) - IRMQTTServer: Support for multiple climates. (#903) - IRMQTTServer: Add TX channel support for HTTP interface. (#929) - IRMQTTServer: Add option to clear retained settings. (#917) - auto_analyse_raw_data.py: Add decode code generation. (#909) - auto_analyse_raw_data.py: General improvements (#906) **[Misc]** - IRMQTTServer: Use latest API for common A/C. (#928) - IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919) - IRMQTTServer: Move from ArduinoJson v5 to v6. (#878) - IRMQTTServer: Use retain for discovery message. (#881) - Goodweather: Adjust timings & minor fixes. (#924) - PanasonicAc: Add better SwingV support for common a/c framework. (#923) - Daikin2: Corrections for common A/C interface. (#910) - MitsubishiAC: Improve decoding. (#914) - Fujitsu: Disable horiz swing for ARRY4. (#907) - SamsungAc: Only send power on/off code if it's needed. (#884) - Teco: Add timer support. (#883) - More consistent A/C `::toString()` output. (#920)
_v2.6.6 (20190923)_ **[Bug Fixes]** - Ensure `begin()` is called for every supported common a/c. (#905, #899) - IRMQTTServer: Fix JSON state parsing. (#896) - IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893) **[Features]** - Mitsubishi136: Full A/C support. (#898, #890) - Fujitsu: Add support for ARRY4 remote. (#895) - Web-AC-control: Add new WebUI example sketch. (#880, #886) - Improve Common A/C API (#913) - IRMQTTServer: Support for multiple climates. (#903) - IRMQTTServer: Add TX channel support for HTTP interface. (#929) - IRMQTTServer: Add option to clear retained settings. (#917) - auto_analyse_raw_data.py: Add decode code generation. (#909) - auto_analyse_raw_data.py: General improvements (#906) **[Misc]** - IRMQTTServer: Use latest API for common A/C. (#928) - IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919) - IRMQTTServer: Move from ArduinoJson v5 to v6. (#878) - IRMQTTServer: Use retain for discovery message. (#881) - Goodweather: Adjust timings & minor fixes. (#924) - PanasonicAc: Add better SwingV support for common a/c framework. (#923) - Daikin2: Corrections for common A/C interface. (#910) - MitsubishiAC: Improve decoding. (#914) - Fujitsu: Disable horiz swing for ARRY4. (#907) - SamsungAc: Only send power on/off code if it's needed. (#884) - Teco: Add timer support. (#883) - More consistent A/C `::toString()` output. (#920)
FYI, the changes mentioned above are included in the newly released version of the library (v2.6.6). |
KEY_CHANNEL
) argument to control which TX channel to send to.genStatTopic()