chore: update packages/example deployment script and cleanup package/example #25091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
rge branch 'update-examples-deployment' of https://github.com/cypress-io/cypress into update-examples-deployment
47 flaky tests on run #43525 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse | ||
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| cy.origin waiting > alias > waits for the route alias to have a response | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| ... > runs generated spec |
Screenshot
|
|
specs_list_latest_runs.cy.ts • 2 flaky tests • app-e2e
The first 5 flaky specs are shown, see all 25 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
approved these changes
Dec 11, 2022
| // This example support/e2e.js is processed and | ||
| // loaded automatically before your test files. | ||
| // | ||
| // This is a great place to put global configuration and |
There was a problem hiding this comment.
I wonder if we should deprecate this library, it has a total for 44 weekly downloads: https://www.npmjs.com/package/create-cypress-tests?activeTab=versions
| @@ -1,28 +1,29 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| /* eslint-disable no-console */ | |||
There was a problem hiding this comment.
Did we need this? I don't see any console.log added here.
There was a problem hiding this comment.
see lines 31 & 34
emilyrohrbough
changed the title
AtofStryker
requested changes
Jan 27, 2023
Co-authored-by: Bill Glesias <[email protected]>
AtofStryker
approved these changes
Jan 27, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 31, 2023
* develop: chore: fix changlelog section parsing and reference right ENV (#25633) feat: Debug page [IATR] (#25488) fix(deps): update dependency underscore.string to v3.3.6 🌟 (#25574) chore: Use upstream cypress-testing-library again (#25548) fix: match alternate edge version string format (#25457) chore: update name for graphql batch operations (#25610) chore: clean up config for external contibutors (#25552) chore: fix childProcess.execSync encoding (#25625) chore: update next-version to handle using the next bump package.json… (#25599) chore: update packages/example deployment script and cleanup package/example (#25091) fix: allow version 9 of the babel-loader peer dependency (#25569) docs: remove cypress-example-todomvc-redux from release-process (#25613) chore: bump version and remove misleading changelog entry (#25612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing deployment issues with
packages/example, cleaning up dead code, auto-fix lint changes and updated README to reflect current usage.