-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up config for external contibutors #25552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
commented
Jan 24, 2023
emilyrohrbough
commented
Jan 24, 2023
mjhenkes
approved these changes
Jan 24, 2023
estrada9166
approved these changes
Jan 24, 2023
AtofStryker
approved these changes
Jan 24, 2023
Full disclosure. After helping @estrada9166 some more, I think we have also tightened our restrictions around our context sharing and env passing in CircleCI where this will allow CircleCI to kick-off but anywhere were contexts/envs are referenced, contributes who are not apart of the App Team will received "Unauthorized". |
tgriesser
added a commit
that referenced
this pull request
Jan 31, 2023
* develop: chore: fix changlelog section parsing and reference right ENV (#25633) feat: Debug page [IATR] (#25488) fix(deps): update dependency underscore.string to v3.3.6 🌟 (#25574) chore: Use upstream cypress-testing-library again (#25548) fix: match alternate edge version string format (#25457) chore: update name for graphql batch operations (#25610) chore: clean up config for external contibutors (#25552) chore: fix childProcess.execSync encoding (#25625) chore: update next-version to handle using the next bump package.json… (#25599) chore: update packages/example deployment script and cleanup package/example (#25091) fix: allow version 9 of the babel-loader peer dependency (#25569) docs: remove cypress-example-todomvc-redux from release-process (#25613) chore: bump version and remove misleading changelog entry (#25612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the limited CI runs in Circle, I wrote it to cancel the workflow to make it understood the full workflow did not run. Circle does not provide a first-class way to cancel the pipeline, so I leveraged their API to cancel it. However to do so, a
CIRCLE_TOKEN
was required to authenticate.This process worked fine for cypress members, but resulted in
Unathorized
CircleCI kickoff. (example)It appears @estrada9166 is not apart of the Cypress App github team, and was experiencing this issue. He applied this change here:
8581950
(#25237)And the job was successfully kicked off: https://app.circleci.com/pipelines/github/cypress-io/cypress/48589
Closes #25553