-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow version 9 of the babel-loader peer dependency #25569
fix: allow version 9 of the babel-loader peer dependency #25569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense, we don't want to block users if they want to use newer deps.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Holding off on merging as we have a planned patch release to fix a regression with 12.4.0. Once we get that out I'll merge this! |
Hi team, thanks for the merge. Any ETA on a release for the @cypress/webpack-preprocessor npm package? |
@arnaugiralt It should be released with the next green develop build! (I'm assuming you're using |
* develop: chore: fix changlelog section parsing and reference right ENV (#25633) feat: Debug page [IATR] (#25488) fix(deps): update dependency underscore.string to v3.3.6 🌟 (#25574) chore: Use upstream cypress-testing-library again (#25548) fix: match alternate edge version string format (#25457) chore: update name for graphql batch operations (#25610) chore: clean up config for external contibutors (#25552) chore: fix childProcess.execSync encoding (#25625) chore: update next-version to handle using the next bump package.json… (#25599) chore: update packages/example deployment script and cleanup package/example (#25091) fix: allow version 9 of the babel-loader peer dependency (#25569) docs: remove cypress-example-todomvc-redux from release-process (#25613) chore: bump version and remove misleading changelog entry (#25612)
Additional details
There is a dependency issue between babel-loader and @cypress/webpack-preprocessor. The installation of this newer babel-loader version should not cause package install issues. The user should be able to install both v8 and v9 of @babel/loader.
Steps to test
Just forcing an install with babel-loader@^9 is enough to test that everything works.
Since the main breaking change in v9 is dropping Webpack v4 and @cypress/webpack-preprocessor already allows for v5, I think it is safe to allow this change. If necessary, we could also update the @babel/core peer dependency to ^7.12, but babel-loader already has it declared as a peer dependency, so as you see fit.
PR Tasks
cypress-documentation
?type definitions
?