[firehose] Set exit code and return instead of calling exit(X) #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exit(x) break debuggers!
|
also: might as go v1, what are we waiting for? 😁 |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. |
devoncarew
approved these changes
Feb 10, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/5b0d815..fe4979b): fe4979b 2025-02-10 Kevin Moore [firehose] Set exit code and return instead of calling exit(X) (dart-lang/ecosystem#341) http (https://github.com/dart-lang/http/compare/b7cdf61..e28f9f5): e28f9f5 2025-02-11 Sam Rawlins Fix typo in example in README (dart-lang/http#1714) fc59d4a 2025-02-11 Brian Quinlan Revert cronet_http gradle version (dart-lang/http#1712) protobuf (https://github.com/dart-lang/protobuf/compare/d00f905..610943a): 610943a 2025-02-12 Devon Carew update the publish workflow; add a post_summaries one (google/protobuf.dart#961) 35a1bd6 2025-02-12 Devon Carew update the repo analysis config (google/protobuf.dart#962) d3f9ad1 2025-02-12 Devon Carew updates to the gitignore files (google/protobuf.dart#960) 950b6a7 2025-02-11 Ömer Sinan Ağacan Remove redundant checkNotNull calls from pre-null-safe days (google/protobuf.dart#958) shelf (https://github.com/dart-lang/shelf/compare/2a7442f..b39e611): b39e611 2025-02-11 dependabot[bot] Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/shelf#470) webdev (https://github.com/dart-lang/webdev/compare/616da45..718c39c): 718c39c3 2025-02-11 Jessy Yameogo set packageConfigPath and update DWDS version to 24.3.5 (dart-lang/webdev#2589) 4246bbc5 2025-02-11 Jessy Yameogo Added method findPackageConfigFilePath to find the package_config.json file (dart-lang/webdev#2587) Change-Id: I7e5940ad3b128d1e47c2185a1435006c2a277bc4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409621 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exit(x) break debuggers!