Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cronet_http gradle version #1712

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

brianquinlan
Copy link
Collaborator

It was accidentally changed in c7cc4f8


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cronet_http Non-Breaking 1.3.2 1.3.3-wip 1.4.0
Got "1.3.3-wip" expected >= "1.4.0" (non-breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart

@brianquinlan brianquinlan merged commit fc59d4a into dart-lang:master Feb 11, 2025
33 of 34 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/5b0d815..fe4979b):
  fe4979b  2025-02-10  Kevin Moore  [firehose] Set exit code and return instead of calling exit(X) (dart-lang/ecosystem#341)

http (https://github.com/dart-lang/http/compare/b7cdf61..e28f9f5):
  e28f9f5  2025-02-11  Sam Rawlins  Fix typo in example in README (dart-lang/http#1714)
  fc59d4a  2025-02-11  Brian Quinlan  Revert cronet_http gradle version (dart-lang/http#1712)

protobuf (https://github.com/dart-lang/protobuf/compare/d00f905..610943a):
  610943a  2025-02-12  Devon Carew  update the publish workflow; add a post_summaries one (google/protobuf.dart#961)
  35a1bd6  2025-02-12  Devon Carew  update the repo analysis config (google/protobuf.dart#962)
  d3f9ad1  2025-02-12  Devon Carew  updates to the gitignore files (google/protobuf.dart#960)
  950b6a7  2025-02-11  Ömer Sinan Ağacan  Remove redundant checkNotNull calls from pre-null-safe days (google/protobuf.dart#958)

shelf (https://github.com/dart-lang/shelf/compare/2a7442f..b39e611):
  b39e611  2025-02-11  dependabot[bot]  Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/shelf#470)

webdev (https://github.com/dart-lang/webdev/compare/616da45..718c39c):
  718c39c3  2025-02-11  Jessy Yameogo  set packageConfigPath and update DWDS version to 24.3.5 (dart-lang/webdev#2589)
  4246bbc5  2025-02-11  Jessy Yameogo  Added method findPackageConfigFilePath to find the package_config.json file (dart-lang/webdev#2587)

Change-Id: I7e5940ad3b128d1e47c2185a1435006c2a277bc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409621
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants