Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the publish workflow; add a post_summaries one #961

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

devoncarew
Copy link
Collaborator

  • update the publish workflow to write its comment to a workflow file
  • add a post_summaries workflow - pull from the file and comment on the current PR

This config will allow PRs from forks to still get feedback in the PR from the publish workflow.

Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting...is this because it's not our org?

@devoncarew
Copy link
Collaborator Author

This is the new best practice for setting up the publish (or health) workflows. cc @mosuem

@mosuem
Copy link

mosuem commented Feb 12, 2025

interesting...is this because it's not our org?

Unfortunately, this is a general Github thing.

@devoncarew devoncarew merged commit 610943a into google:master Feb 12, 2025
17 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/5b0d815..fe4979b):
  fe4979b  2025-02-10  Kevin Moore  [firehose] Set exit code and return instead of calling exit(X) (dart-lang/ecosystem#341)

http (https://github.com/dart-lang/http/compare/b7cdf61..e28f9f5):
  e28f9f5  2025-02-11  Sam Rawlins  Fix typo in example in README (dart-lang/http#1714)
  fc59d4a  2025-02-11  Brian Quinlan  Revert cronet_http gradle version (dart-lang/http#1712)

protobuf (https://github.com/dart-lang/protobuf/compare/d00f905..610943a):
  610943a  2025-02-12  Devon Carew  update the publish workflow; add a post_summaries one (google/protobuf.dart#961)
  35a1bd6  2025-02-12  Devon Carew  update the repo analysis config (google/protobuf.dart#962)
  d3f9ad1  2025-02-12  Devon Carew  updates to the gitignore files (google/protobuf.dart#960)
  950b6a7  2025-02-11  Ömer Sinan Ağacan  Remove redundant checkNotNull calls from pre-null-safe days (google/protobuf.dart#958)

shelf (https://github.com/dart-lang/shelf/compare/2a7442f..b39e611):
  b39e611  2025-02-11  dependabot[bot]  Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/shelf#470)

webdev (https://github.com/dart-lang/webdev/compare/616da45..718c39c):
  718c39c3  2025-02-11  Jessy Yameogo  set packageConfigPath and update DWDS version to 24.3.5 (dart-lang/webdev#2589)
  4246bbc5  2025-02-11  Jessy Yameogo  Added method findPackageConfigFilePath to find the package_config.json file (dart-lang/webdev#2587)

Change-Id: I7e5940ad3b128d1e47c2185a1435006c2a277bc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409621
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants