Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order can't selects many Shipping Option #141

Closed
simonLouvet opened this issue Jul 11, 2024 · 10 comments
Closed

Order can't selects many Shipping Option #141

simonLouvet opened this issue Jul 11, 2024 · 10 comments
Assignees

Comments

@simonLouvet
Copy link
Contributor

I need to identify the pick-up and delivery points for orders, but the Order class selects one and only one Shipping Option.

@RachL
Copy link
Member

RachL commented Jul 11, 2024

Just to be sure: an order can have several shipping options but a real order has in the end only one shipping method ?

@RaggedStaff
Copy link
Contributor

I think @simonLouvet is referring to the logistics issue that an Order needs to be collected from somewhere & delivered to somewhere else.

I don't think that is the same as having a pickupOption & deliveryOption.

I think we did discuss this in a ontology call but it was a long time ago & I can't find the diagram that @Alcoz did.

Baptiste - can you recall what was discussed/agreed ?

@RaggedStaff
Copy link
Contributor

RaggedStaff commented Jul 11, 2024

Notes from [slack discussion}(https://datafoodconsortium.slack.com/archives/C020KLNTDF0/p1719489678423519):

I think you might need to use the hostedAt property from SaleSession for the pickup Place on the Order details. It's a hack, but I don't think we have this in the Ontology currently (& it should be the same for all the deliveries from a single SaleSession, yes?) .

Further notes from Ontology Call:

ShippingOption is selected by Customer, so shouldn't be used for logistics work.

LocalizedProduct & PhysicalProduct points to Stock, which points to a PhysicalPlace (either localizedBy or isStoredIn respectively) - that is where the Product is located, and should be the collection point for logistics.

@RaggedStaff RaggedStaff moved this from Backlog to Done in Ontology Team Task Board Jul 11, 2024
@RaggedStaff RaggedStaff closed this as completed by moving to Done in Ontology Team Task Board Jul 11, 2024
@RaggedStaff RaggedStaff moved this from Done to To Review in Ontology Team Task Board Jul 11, 2024
@RaggedStaff RaggedStaff reopened this Jul 11, 2024
@lecoqlibre
Copy link
Member

So @simonLouvet to get point of departure you have to look for the location of each LocalizedProduct or PhysicalProduct of the order.

The point of arrival is the location linked to the shipping option chosen by the customer.

@simonLouvet
Copy link
Contributor Author

simonLouvet commented Jul 11, 2024

Ok but in m'y exemple i have only definedProduct. I need ton create a New product with a New uri or change type oh my products?

@lecoqlibre
Copy link
Member

Yes, each Supplied product should be linked to a Localized and even a Physical product (if the product is real or physically stored at some place). Therefore new URIs should be created.

@simonLouvet
Copy link
Contributor Author

ok @lecoqlibre, but that doesn't solve my basic need.
An OrderLine concerns a DefinedProduct. How can we determine which is the LocalizedProduct of this DefinedProduct? Why doesn't an OrderLine concern a LocalizedProduct? I still don't understand how I find out where the product to be shipped is located.

@RaggedStaff
Copy link
Contributor

Proposal to link 1 OrderLine directly to 1 PhysicalProduct (fulfils the OrderLine). This is in addition to the link to SuppliedProduct (via Offer/CatalogItem).

The Supplier must provide this link (but not until Order completion/fulfilment). It may be provided at Order creation, if available.

@simonLouvet
Copy link
Contributor Author

@RaggedStaff @Alcoz @lecoqlibre
here's the state of my test dataset by uncluding the relationship between orderLine and PhycicalProduct
https://github.com/datafoodconsortium/business-api/blob/main/user.json

Alcoz added a commit that referenced this issue Sep 10, 2024
Alcoz added a commit that referenced this issue Oct 3, 2024
* #141 #37 #131 #136 #132

* Add Price on OrderLine
@RaggedStaff
Copy link
Contributor

Closed as part of PR #146

@github-project-automation github-project-automation bot moved this from In Progress to Done in Ontology Team Task Board Oct 3, 2024
Alcoz added a commit that referenced this issue Nov 12, 2024
* fix context & chengelog bottom links

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* GH - added initial drafts of Bug & feature request templates

* add first versioned context.json (#121)

* create file

* add changelog

* owner to technical ontology

---------

Co-authored-by: simon louvet <[email protected]>

* Add inverse `belongsTo` property to resolve #118 (#124)

* Add inverse relationship of belongsTo called holds

* Update context for issue 118

* Update changelog version

* 111 (#126)

* update sold by sells

* Update context for issue 111

* Add of Weigth, Length and Volume as subclass of QuantitativeValue (#127)

* Add of Weigth, Length and Volume as subclass of QuantitativeValue

* Update CHANGELOG.md

* add missing inverse relationship (#128)

* add missing inverse relationship

* Update CHANGELOG.md

* Fix DFC_BusinessOntology.owl file  (#139)

* added missing <InverseObjectProperties> for sells/soldB to fix owl file not loading in Protege.

* Removed chk files & updated gitignore

* Fixed concerns property for OrderLine to be constrained to Offer, not DefinedProduct (#144)

* #141 #37 #131 #136 #132 (#146)

* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add of definitions in ontology files (#147)

* update CHANGELOG.md and add context_1.14.0.json

* fix changelog

* fix changelog

* fix merge issue and clean changelog

* fix changelog

---------

Co-authored-by: simon louvet <[email protected]>
Co-authored-by: RaggedStaff <[email protected]>
Co-authored-by: simonLouvet <[email protected]>
Alcoz added a commit that referenced this issue Dec 4, 2024
* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add variant and deprecate quantity dataproperty
Alcoz added a commit that referenced this issue Jan 9, 2025
* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add variant and deprecate quantity dataproperty

* Add shipment, vehicle and related properties to logistic use-case

* missing small update

* GH - Added comments for new concepts.

* add property between shipment and vehicle

* generate context for 1.15.0

---------

Co-authored-by: RaggedStaff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants