Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Characteristic generic hasDimension predicate instead of hasNutrientDimension, hasPhysicalDimension and hasAllergenDimension #37

Closed
lecoqlibre opened this issue Oct 14, 2022 · 0 comments

Comments

@lecoqlibre
Copy link
Member

Does it make sense to replace hasNutrientDimension, hasPhysicalDimension and hasAllergenDimension from NutrientCharacteristic, PhysicalCharacteristic and AllergenCharacteristic with just hasDimension like in the following snippet ?

      "dfc-b:hasNutrientCharacteristic": {
          "@type":"dfc-b:NutrientCharacteristic",
          "dfc-b:hasDimension":"dfc-m:Magnesium",
          "dfc-b:hasUnit":"dfc-m:Gram",
          "dfc-b:value":"10"
      },
      "dfc-b:hasPhysicalCharacteristic": {
          "@type":"dfc-b:PhysicalCharacteristic",
          "dfc-b:hasDimension":"dfc-m:Weight",
          "dfc-b:hasUnit":"dfc-m:Gram",
          "dfc-b:value":"100"
      },
      "dfc-b:hasAllergenCharacteristic": {
          "@type":"dfc-b:AllergenCharacteristic",
          "dfc-b:hasDimension":"dfc-m:allergenCharacteristic1",
          "dfc-b:hasUnit":"dfc-m:Allenit1",
          "dfc-b:value":"1"
      }

Doing so would ease the source code of the connector as one super class Characteristic could be used as a base class for each derived NutrientCharacteristic, PhysicalCharacteristic and AllergenCharacteristic classes.

@github-project-automation github-project-automation bot moved this to New issues 🆕 (to triage) in Prototype board Apr 17, 2023
@Alcoz Alcoz closed this as completed Oct 5, 2023
@github-project-automation github-project-automation bot moved this from New issues 🆕 to Done 🥳 in Prototype board Oct 5, 2023
Alcoz added a commit that referenced this issue Sep 10, 2024
Alcoz added a commit that referenced this issue Oct 3, 2024
* #141 #37 #131 #136 #132

* Add Price on OrderLine
Alcoz added a commit that referenced this issue Nov 12, 2024
* fix context & chengelog bottom links

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* add object properties needed by prototype

* GH - added initial drafts of Bug & feature request templates

* add first versioned context.json (#121)

* create file

* add changelog

* owner to technical ontology

---------

Co-authored-by: simon louvet <[email protected]>

* Add inverse `belongsTo` property to resolve #118 (#124)

* Add inverse relationship of belongsTo called holds

* Update context for issue 118

* Update changelog version

* 111 (#126)

* update sold by sells

* Update context for issue 111

* Add of Weigth, Length and Volume as subclass of QuantitativeValue (#127)

* Add of Weigth, Length and Volume as subclass of QuantitativeValue

* Update CHANGELOG.md

* add missing inverse relationship (#128)

* add missing inverse relationship

* Update CHANGELOG.md

* Fix DFC_BusinessOntology.owl file  (#139)

* added missing <InverseObjectProperties> for sells/soldB to fix owl file not loading in Protege.

* Removed chk files & updated gitignore

* Fixed concerns property for OrderLine to be constrained to Offer, not DefinedProduct (#144)

* #141 #37 #131 #136 #132 (#146)

* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add of definitions in ontology files (#147)

* update CHANGELOG.md and add context_1.14.0.json

* fix changelog

* fix changelog

* fix merge issue and clean changelog

* fix changelog

---------

Co-authored-by: simon louvet <[email protected]>
Co-authored-by: RaggedStaff <[email protected]>
Co-authored-by: simonLouvet <[email protected]>
Alcoz added a commit that referenced this issue Dec 4, 2024
* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add variant and deprecate quantity dataproperty
Alcoz added a commit that referenced this issue Jan 9, 2025
* #141 #37 #131 #136 #132

* Add Price on OrderLine

* Add variant and deprecate quantity dataproperty

* Add shipment, vehicle and related properties to logistic use-case

* missing small update

* GH - Added comments for new concepts.

* add property between shipment and vehicle

* generate context for 1.15.0

---------

Co-authored-by: RaggedStaff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

No branches or pull requests

3 participants