Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant creation and deprecate quantity dataproperty #163

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Add variant creation and deprecate quantity dataproperty #163

merged 6 commits into from
Dec 4, 2024

Conversation

Alcoz
Copy link
Collaborator

@Alcoz Alcoz commented Nov 20, 2024

Added

Property

  • hasVariant, domain: DefinedProduct, inverseOf: isVariantOf
  • isVariantOf, domain: DefinedProduct, inverseOf : hasVariant

Deleted

Property

  • quantity

Changed

  • Domain : hasQuantity, (DefinedProduct | Ingredient | OrderLine) -> (ConsumptionFlow | DefinedProduct | Ingredient | LocalizedProduct | OrderLine | PhysicalProduct | ProductionFlow | SaleSession | ShippingOption | Stock | Transaction)

@Alcoz Alcoz self-assigned this Nov 20, 2024
RaggedStaff
RaggedStaff reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@RaggedStaff RaggedStaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit confused by the removal of the large number of dfc-f Declarations.
Otherwise looks good to go.

src/DFC_BusinessOntology.owl
@@ -1303,474 +1309,6 @@
<Declaration>
<Datatype abbreviatedIRI="xsd:duration"/>
</Declaration>
<Declaration>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only just introduced these Declarations (with the Business Definitions), do we not need them ? 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing them, it should be noted in CHANGELOG.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really strange because it looks like these declarations are coming from the facets taxonomies which is imported now so that's normal they don't belong to this file. However, I didn't change anything regarding this question when I worked on it so I don't know what I did, but this happened. I can update the changelog

src/DFC_BusinessOntology.owl
@@ -5904,9 +5454,17 @@
<ObjectPropertyDomain>
<ObjectProperty IRI="#hasQuantity"/>
<ObjectUnionOf>
<Class IRI="#ConsumptionFlow"/>
<Class IRI="#DefinedProduct"/>
<Class IRI="#Ingredient"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just noting Ingredient wasn't ever linked to the deprecated #quantity DataProperty. Is it too new ? 🤨

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but there were many problems with the Ingredient class because it disappeared during several update. Maybe I recreated the Ingredient class directly with the right property

@Alcoz Alcoz merged commit 4e0ac3d into next-ontology Dec 4, 2024
lecoqlibre added a commit that referenced this pull request Jan 16, 2025
@lecoqlibre
Add version 1.15
2aec57d 
- Add variant creation and deprecate quantity dataproperty (#163)
- Add shipment, vehicle and related properties to logistic use-case (#169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaggedStaff RaggedStaff RaggedStaff left review comments

@lecoqlibre lecoqlibre lecoqlibre approved these changes

Assignees

@Alcoz Alcoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alcoz @lecoqlibre @RaggedStaff