feat(DataPlatform): Introducing optional DataPlatform logoUrl field #2127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR introduces an optional logoUrl field in the
DataPlatformInfo
PDL. The motivation is we would like to display platform-specific logos on the UI. This approach will allow us to drive the logo shown in the React experience from the server, as opposed to hardcoding specific logo images in the frontend code on a per-platform basis, with the idea being to reduce the frequency frontend code needs to be updated in cases of customization. It also allows individual organizations to change logos for a particular platform as they wish.Changes
datahub-graphql-core
to include the optional logoUrl field.Validation
Validated this change by adding a test logoUrl to
DataPlatformInfo.json
file locally. Deployed a local version of gms and datahub-frontend, was able to fetch the logoUrl provided in the json configuration file without issue.Checklist