Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DataPlatform): Introducing optional DataPlatform logoUrl field #2127

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Feb 19, 2021

Scope
This PR introduces an optional logoUrl field in the DataPlatformInfo PDL. The motivation is we would like to display platform-specific logos on the UI. This approach will allow us to drive the logo shown in the React experience from the server, as opposed to hardcoding specific logo images in the frontend code on a per-platform basis, with the idea being to reduce the frequency frontend code needs to be updated in cases of customization. It also allows individual organizations to change logos for a particular platform as they wish.

Changes

  1. Add optional "logoUrl" field to DataPlatformInfo object (not a breaking change)
  2. Update GQL API in datahub-graphql-core to include the optional logoUrl field.

Validation
Validated this change by adding a test logoUrl to DataPlatformInfo.json file locally. Deployed a local version of gms and datahub-frontend, was able to fetch the logoUrl provided in the json configuration file without issue.

Checklist

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 4f8d8b3 into datahub-project:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants