Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity level commit order #10792

Merged

Conversation

greg0ire
Copy link
Member

No description provided.

mpdude and others added 30 commits February 13, 2023 20:46
missing ';' on Obtaining the EntityManager section, bootstrap code line 32
…ve-to-many-lazy-check

Make "targetEntity must not be a mapped superclass" a lazy check
DiscriminatorColumnMapping is just a specialization of the array shape
that is right of the pipe: it has the same fields, except fewer fields
are nullable. The union of that is the same thing as the array shape.
It looks like some issues are now represented by different classes.
fix(persistent-collection): check association is not nullable before using it as an array
When an entity have a backed enum as identifier, `UnitOfWork` tries to
cast to string when generating the hash of the id.
This fix calls `->value` when identifier is a `BackedEnum`.
Fixes doctrine#10471
Fixes doctrine#10334
…ciation

Deprecate overriding associations not inherited from a mapped superclass
* Add test case for doctrine#7717

* Do not hide null equality checks in `SqlValueVisitor::walkComparison`

* Annotate `GH7717Parent::$children` type
fix typo in HydrationCompleteHandler doc
After update to orm 2.14.2 invalid xsd schema error is occured, when in field,id or attribute-override have type is FQCN
…mapping

Fixed xsd schema for support FQCN type
…2.15.x_VZV5I0St

Merge release 2.14.3 into 2.15.x
greg0ire and others added 28 commits June 3, 2023 20:59
This is the result of the contradiction between the phpdoc
(ClassMetadata), and the condition, which guarantees $metadata is not a
ClassMetadata. Relaxing the phpdoc leads to other phpstan issues, about
properties that exist in ClassMetadata but not in
PersistentClassMetadata. The right way to fix this would be to switch
from a deprecation to an exception, but that is not the path we have
taken, and all this will disappear in 3.0.x anyway, so let's not bother.
… for orphan removal.

In my case a custom doctrine type of Uuid object is converted to string by simply casting it, resulting in a hex DELETE FROM x WHERE id = ? query,
whilst it should've been converted along the way to it's binary representation. This leads to no deletions being made at all as you would expect making use of doctrine custom type's as an identifier.

This commit fixes usage of ramsey/uuid or symfony/uid as custom id types when making use of orphan removal.
It brings nothing over what PHPUnit now natively does.
Partial objects are deprecated. They were handy to make the generated
SQL more legible, but we should refrain from relying on them.
When collection updates/join table cleanups do not happen through specialized Entity-/CollectionPersister methods but instead as "plain" updates, we may issue a lot more queries than expected.
I tweaked the code so that it would not fall victim to
slevomat/coding-standard#1585 or
slevomat/coding-standard#1586, thus fixing the
phpcs job without losing information or breaking other jobs.
Work around slevomat/coding-standard issues
@greg0ire greg0ire merged commit f778d8c into doctrine:entity-level-commit-order Jun 23, 2023
@greg0ire greg0ire deleted the entity-level-commit-order branch June 23, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.