Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple opentelemetry from tracing #222

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Decouple opentelemetry from tracing #222

merged 2 commits into from
Mar 15, 2023

Conversation

phil-opp
Copy link
Collaborator

Only the dora-runtime uses the opentelemetry features right now, but most other crates depend on our tracing sub-crate too after #197. This PR adds a new telemetry feature to allow enabling the tracing-subscriber without bringing in the whole opentelementry dependency tree.

The `tracing` feature just enables the tracing subscriber, the `telemetry` feature the `opentelemetry` integration.
@phil-opp phil-opp requested a review from haixuanTao March 15, 2023 13:51
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@haixuanTao haixuanTao merged commit 9a4219e into main Mar 15, 2023
@haixuanTao haixuanTao deleted the optional-telemetry branch March 15, 2023 17:00
haixuanTao added a commit that referenced this pull request Mar 22, 2023
* [Make dora-rs publishable on crates.io](#211)
* [Add an internal cli argument to create template with path dependencies](#212)

* [Avoid blocking the daemon main loop by using unbounded queue](#230)
* [Inject YAML declared env variable into the runtime](#227)
* [Use rustls instead of system SSL implementation](#216)

* [Refactor python error](#229)
* [The first letter of rust should be lowercase in the command](#226)
* [Add documentation to the cli within the helper mode](#225)
* [Update to safer-ffi v0.1.0-rc1](#218)
* [remove unused variable: data_bytes](#215)
* [Clean up: Remove workspace path](#210)
* [Decouple opentelemetry from tracing](#222)
* [Remove zenoh dependency from dora node API to speed up build](#220)
* [Update to Rust v1.68](#221)
* [Deny unknown fields to avoid typos](#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants