Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny unknown fields to avoid typos #223

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Deny unknown fields to avoid typos #223

merged 2 commits into from
Mar 16, 2023

Conversation

haixuanTao
Copy link
Collaborator

This pull request deny dataflow with misspelled field.

Ex:

  - id: object_detection
    custom:
      source: ./object_detection.py
      input: # missing a `s`
        image: webcam/image

@haixuanTao haixuanTao requested a review from phil-opp March 16, 2023 12:18
phil-opp
phil-opp reviewed Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@phil-opp phil-opp merged commit 49468b4 into main Mar 16, 2023
@phil-opp phil-opp deleted the deny-unknown-field branch March 16, 2023 16:05
@phil-opp phil-opp changed the title Deny unknown field to avoid typography Deny unknown fields to avoid typos Mar 16, 2023
haixuanTao added a commit that referenced this pull request Mar 22, 2023
@haixuanTao
Bump Dora version to 0.2.1
eab3c8c 
* [Make dora-rs publishable on crates.io](#211)
* [Add an internal cli argument to create template with path dependencies](#212)

* [Avoid blocking the daemon main loop by using unbounded queue](#230)
* [Inject YAML declared env variable into the runtime](#227)
* [Use rustls instead of system SSL implementation](#216)

* [Refactor python error](#229)
* [The first letter of rust should be lowercase in the command](#226)
* [Add documentation to the cli within the helper mode](#225)
* [Update to safer-ffi v0.1.0-rc1](#218)
* [remove unused variable: data_bytes](#215)
* [Clean up: Remove workspace path](#210)
* [Decouple opentelemetry from tracing](#222)
* [Remove zenoh dependency from dora node API to speed up build](#220)
* [Update to Rust v1.68](#221)
* [Deny unknown fields to avoid typos](#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haixuanTao @phil-opp