Avoid blocking the daemon main loop by using unbounded queue #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main loop of the daemon should not be blocked at any time.
haixuanTao
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Nice! I just tested and it works very well!
It might even be a bit faster,
Latency is the last column in nanoseconds
From:
name, platform, Msg Size in Bit, Latency
dora-rs daemon Python,[email protected],8,792.4573099990084
dora-rs daemon Python,[email protected],64,747.8795000008629
dora-rs daemon Python,[email protected],512,799.8767300040299
dora-rs daemon Python,[email protected],2048,711.45794000131
dora-rs daemon Python,[email protected],4096,865.6043299993144
dora-rs daemon Python,[email protected],16384,890.8924600001457
dora-rs daemon Python,[email protected],40960,1007.7704199989056
dora-rs daemon Python,[email protected],409600,1250.2376100025003
dora-rs daemon Python,[email protected],4096000,7941.366180000956
dora-rs daemon Python,[email protected],40960000,53663.645750003765
To
dora-rs daemon Python,[email protected],8,508.10982938855886
dora-rs daemon Python,[email protected],64,503.40708054136485
dora-rs daemon Python,[email protected],512,569.5853204815648
dora-rs daemon Python,[email protected],2048,799.5779596967623
dora-rs daemon Python,[email protected],4096,500.8382411324419
dora-rs daemon Python,[email protected],16384,502.8422095347196
dora-rs daemon Python,[email protected],40960,545.0415704399347
dora-rs daemon Python,[email protected],409600,775.8157313219272
dora-rs daemon Python,[email protected],4096000,4016.9729199260473
dora-rs daemon Python,[email protected],40960000,53985.91389093781This is not a precise test, I just runned it a handful of time
|
Great, thanks for testing! |
haixuanTao
added a commit
that referenced
this pull request
Mar 22, 2023
* [Make dora-rs publishable on crates.io](#211) * [Add an internal cli argument to create template with path dependencies](#212) * [Avoid blocking the daemon main loop by using unbounded queue](#230) * [Inject YAML declared env variable into the runtime](#227) * [Use rustls instead of system SSL implementation](#216) * [Refactor python error](#229) * [The first letter of rust should be lowercase in the command](#226) * [Add documentation to the cli within the helper mode](#225) * [Update to safer-ffi v0.1.0-rc1](#218) * [remove unused variable: data_bytes](#215) * [Clean up: Remove workspace path](#210) * [Decouple opentelemetry from tracing](#222) * [Remove zenoh dependency from dora node API to speed up build](#220) * [Update to Rust v1.68](#221) * [Deny unknown fields to avoid typos](#223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking the main loop blocks all inputs and outputs, so we should really avoid it. By using unbounded queues to the subscriber tasks we can ensure that the daemon can always forward events immediately. The subscriber tasks will then take care of dropping inputs if the receiver is too slow.
This should fix lag issues that occur when messages are send with high frequency.