-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roslyn Tokenizer #11086
Roslyn Tokenizer #11086
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46698be - Browse repository at this point
Copy the full SHA 46698beView commit details -
Duplicate existing tokenizer and add a flag to control whether to use…
… the roslyn or legacy tokenizers.
Configuration menu - View commit details
-
Copy full SHA for b3f0a12 - Browse repository at this point
Copy the full SHA b3f0a12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14f71e2 - Browse repository at this point
Copy the full SHA 14f71e2View commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b3f055a - Browse repository at this point
Copy the full SHA b3f055aView commit details -
Roslyn Tokenizer Infrastructure (#10676)
This is some of the infrastructure that will be needed to get the Roslyn tokenizer in. We'll have the new tokenizer, and an option to switch back to the legacy tokenizer. To make reviewing easier, I would highly suggest going commit-by-commit, to make sure that the renames show up as actual renames.
Configuration menu - View commit details
-
Copy full SHA for b9c924b - Browse repository at this point
Copy the full SHA b9c924bView commit details -
Merge remote-tracking branch 'upstream/main' into merge-main
* upstream/main: Disable nullable warnings on .NET Standard and Framework (#10677)
Configuration menu - View commit details
-
Copy full SHA for 4346076 - Browse repository at this point
Copy the full SHA 4346076View commit details -
Configuration menu - View commit details
-
Copy full SHA for a35513a - Browse repository at this point
Copy the full SHA a35513aView commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 894a9ba - Browse repository at this point
Copy the full SHA 894a9baView commit details -
Configuration menu - View commit details
-
Copy full SHA for a15d7cc - Browse repository at this point
Copy the full SHA a15d7ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8fd07 - Browse repository at this point
Copy the full SHA 3a8fd07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60ac8d1 - Browse repository at this point
Copy the full SHA 60ac8d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73aa717 - Browse repository at this point
Copy the full SHA 73aa717View commit details -
Add consolidated syntax kinds. Since there aren't consumers that care…
… about the individual differences between most C# operators, as well the difference between C# numeric types, we'll just use a single kind in the new parser to keep things simpler.
Configuration menu - View commit details
-
Copy full SHA for dcef8ed - Browse repository at this point
Copy the full SHA dcef8edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5749a8e - Browse repository at this point
Copy the full SHA 5749a8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2823f64 - Browse repository at this point
Copy the full SHA 2823f64View commit details -
Configuration menu - View commit details
-
Copy full SHA for c25ac20 - Browse repository at this point
Copy the full SHA c25ac20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ab111 - Browse repository at this point
Copy the full SHA 34ab111View commit details -
Configuration menu - View commit details
-
Copy full SHA for abd6aba - Browse repository at this point
Copy the full SHA abd6abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for acf7a60 - Browse repository at this point
Copy the full SHA acf7a60View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 640d377 - Browse repository at this point
Copy the full SHA 640d377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3155200 - Browse repository at this point
Copy the full SHA 3155200View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0d57d - Browse repository at this point
Copy the full SHA 1a0d57dView commit details
Commits on Aug 6, 2024
-
Additional commenting and PR feedback. I've simplified the reset loop…
… to just be from the back of the results, as that's the most common order for the parser to reset in. I've also refactored a common advance loop to reduce duplication.
Configuration menu - View commit details
-
Copy full SHA for aa24f69 - Browse repository at this point
Copy the full SHA aa24f69View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b7e927 - Browse repository at this point
Copy the full SHA 5b7e927View commit details
Commits on Aug 12, 2024
-
Use the roslyn tokenizer (#10702)
This is the big one: using the Roslyn tokenizer during Razor parsing. I've done my best to separate out various pieces into separate commits to make the review a bit simpler, but there's no getting around the lexer change being complicated. I would recommend commit-by-commit to make it as simple as possible. Fixes #10568, fixes #7084.
Configuration menu - View commit details
-
Copy full SHA for 91bbfde - Browse repository at this point
Copy the full SHA 91bbfdeView commit details -
Merge remote-tracking branch 'upstream/main' into features/roslyn-tok…
…enizer * upstream/main: (53 commits) Move to central package pinning (#10716) Try to fix rename tests Unskip rename tests I spent 10 minutes looking up cool Mr Freeze catch phrases for this commit message, and I didn't like any of them. Clean up CompilationTagHelperResolver Clean up all ITagHelperDescriptorProviders a bit (and found a bug!) Make ExcludeHidden and IncludeDocumentation init-only properties Swap TagHelperDescriptorProviderContext.Create methods for constructors Remove TagHelperDescriptorProviderContext.Items property Make TargetSymbol a TagHelperDescriptorProviderContext property Make Compilation a TagHelperDescriptorProviderContext property Merge TagHelperDescriptorProviderContext and DefaultContext Don't pass code document and source text around in diagnostics translator, plus some cleanup Remove unnecessary parameter, because it can be trivially retrieved Find razor document correctly in RemoveDocumentMappingService Add extension methods that convert URIs to Roslyn file paths Use Uri.LocalPath rather than GetAbsoluteOrUNCPath() Move MapToHostDocuementUriAndRangeAsync to extension methods Fix small typo in comment Remove unused DocumentState method ...
Configuration menu - View commit details
-
Copy full SHA for 711bda8 - Browse repository at this point
Copy the full SHA 711bda8View commit details -
Merge main to tokenizer branch (#10724)
Clean merge, no manual changes required
Configuration menu - View commit details
-
Copy full SHA for 8bf616a - Browse repository at this point
Copy the full SHA 8bf616aView commit details
Commits on Aug 13, 2024
-
Plumb CSharpParseOptions to the tokenizer (#10733)
Does as the tin says. Prerequisite to handling directives, as we'll need the parse options to know what preprocessor symbols are enabled.
Configuration menu - View commit details
-
Copy full SHA for fef2d1c - Browse repository at this point
Copy the full SHA fef2d1cView commit details
Commits on Aug 22, 2024
-
Merge remote-tracking branch 'upstream/main' into merge-main
* upstream/main: (71 commits) Fix after merge PR feedback Bump Roslyn version Moving formatting service to common layer (#10761) Move GetSyntaxTree to document snapshot Inject file path service into the document snapshot Remove code document parameter and just use document snapshot Update NOTICE.txt (#10768) Allow @@ as a fallback (#10752) Rework how we get generated documents Directly test the component definition service in cohosting Add missing test case Defer to C# for component attribute GTD in cohosting Allow LSP and cohosting to provide specialized methods to get a syntax tree for a C# document Dev Container (#10751) Use a proper Try pattern Add tests for co-hosted GTD Rework IDocumentPositionInfoStrategy and use correctly in co-hosted GTD Add DocumentMappingSerice to RazorDocumentServiceBase Move IDocumentPositionInfoStrategy and friends to Workspaces layer ...
Configuration menu - View commit details
-
Copy full SHA for 35871e3 - Browse repository at this point
Copy the full SHA 35871e3View commit details -
Merge main to tokenizer branch (#10781)
Minor touchup of usings and baselines necessary, no functional changes.
Configuration menu - View commit details
-
Copy full SHA for 647126b - Browse repository at this point
Copy the full SHA 647126bView commit details
Commits on Sep 10, 2024
-
Merge remote-tracking branch 'upstream/main' into features/roslyn-tok…
…enizer * upstream/main: (270 commits) Fix after merge PR Feedback Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240905.1 Fix auto insert service after merge from main PR Feedback Use ImmutableArray in SourceTextDiffer too Create a helper method and revert change to shared code, just in case Convert HtmlFormatter to ImmutableArray<TextChange> IEnumarable to ImmutableArray Remove some more usage of LSP types, and simplify ranges to line numbers Use pooled collections in a few more spots Extract common code to helper method Rename some methods to Try... pattern Rename some variables etc. Fix broken tests Get all consuming code compiling again Convert TextEdit to TextChange Remove flaky test OnAutoInsert Cohosting Tests (#10829) Update GetLanguageKind(...) tests and move to Workspaces.Test ...
Configuration menu - View commit details
-
Copy full SHA for d7d4932 - Browse repository at this point
Copy the full SHA d7d4932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea44ba - Browse repository at this point
Copy the full SHA 0ea44baView commit details
Commits on Sep 12, 2024
-
Merge main to tokenizer branch (#10872)
Will call out the merge locations.
Configuration menu - View commit details
-
Copy full SHA for 87dafaf - Browse repository at this point
Copy the full SHA 87dafafView commit details
Commits on Oct 11, 2024
-
Support directive tokenization (#10979)
* Add new preprocessor tests for the old parser, and copy their baselines over to the new parser for comparison. * Add line whitespace tracking for erroring when a preprocessor token isn't the first thing on a line. * Add initial support for parsing directives in the new lexer. * Initial work on plumbing through parser changes to correctly support directives. Many more tests are required. * Add more tests for other control flow blocks * Several misc refactors * Error on def and undef * Start testing beginning-of-line enforcement. * Report a warning when we see potential misplaced directives in disabled text. * Add more tests, include the correct location in warnings. * Usings, recomment GenerateBaselines * Nullable annotations * Update baselines, skip design time verification where tracked by #10981. * Feedback. * More feedback.
Configuration menu - View commit details
-
Copy full SHA for 07b168a - Browse repository at this point
Copy the full SHA 07b168aView commit details
Commits on Oct 15, 2024
-
Enable the new tokenizer for tooling tests (#11010)
* Enable the new tokenizer for tooling tests * Use the new lexer in the integration tests as well. * Move to new lexer in a lot more places
Configuration menu - View commit details
-
Copy full SHA for 99c61dd - Browse repository at this point
Copy the full SHA 99c61ddView commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f584c9 - Browse repository at this point
Copy the full SHA 2f584c9View commit details -
Reset isOnlyWhitespaceOnLine in scenario revealed in IDE test
Also ensure that another IDE test is run with the new lexer.
Configuration menu - View commit details
-
Copy full SHA for 7598fbf - Browse repository at this point
Copy the full SHA 7598fbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfe65f9 - Browse repository at this point
Copy the full SHA dfe65f9View commit details
Commits on Oct 23, 2024
-
Merge remote-tracking branch 'upstream/main' into merge-main
* upstream/main: (290 commits) Add breaking changes document (#11064) Do not extract component into code block (#11069) Fix invalid setttings json (#11062) update MicrosoftSourceBuildIntermediatearcadePackageVersion Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Update source-build team references (#11032) Handle EditorRequired *Changed/*Expression parameters (#11043) Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Avoid ambiguous `object` reference in generic component recovery (#11053) Move culture info check (#11057) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241015.1 Fix code actions integration tests Add option for format on paste (#11039) Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Fix merge to 17.12 version Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Ensure model directives are mapped at runtime (#11007) Fix @inherits mapping for fuse (#10985) ...
Configuration menu - View commit details
-
Copy full SHA for 2aac41c - Browse repository at this point
Copy the full SHA 2aac41cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b81af5 - Browse repository at this point
Copy the full SHA 7b81af5View commit details -
Merge main into the feature branch. Only trivial merge conflicts and baseline updates were needed.
Configuration menu - View commit details
-
Copy full SHA for c724539 - Browse repository at this point
Copy the full SHA c724539View commit details
Commits on Oct 24, 2024
-
* Switch the new lexer off-by-default. * Add a new document for the lexer breaking changes around pragmas. * Update comment. * Feedback Co-authored-by: Jan Jones <[email protected]> --------- Co-authored-by: Jan Jones <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c20c1cd - Browse repository at this point
Copy the full SHA c20c1cdView commit details -
Merge remote-tracking branch 'upstream/main' into merge-main
* upstream/main: Fix resource string (#11079) Update Roslyn.Diagnostics.Analyzers package to latest version Update MS.CA.Analyzers package to 3.11.0 Don't reference MS.CA.BannedApiAnalyzers package directly Version Roslyn.Diagnostics.Analzyers package separately Update dependencies from https://github.com/dotnet/arcade build 20241016.1 Update dependencies from https://github.com/dotnet/arcade build 20241016.1 Update dependencies from https://github.com/dotnet/arcade build 20241016.1
Configuration menu - View commit details
-
Copy full SHA for 6169824 - Browse repository at this point
Copy the full SHA 6169824View commit details -
Merge main to tokenizer branch (#11085)
Trivial conflict resolutions only.
Configuration menu - View commit details
-
Copy full SHA for 927d6a9 - Browse repository at this point
Copy the full SHA 927d6a9View commit details