Collab advanced #241
Open
Collab advanced #241
+330
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename action arguments - Set missing default values
Add correct link to publish jobs
Set version to 0.8.0 snapshot to align with glsp client packages.
* eclipse-glsp#18 Revise Action/Operation API - Remove (unnecessary) generated hashCode() & equals() methods to improve readability - Remove unneeded ActionKinds and handlers (leftovers from initial implementation) - Introduce Registry API for classes that supply data for the server (e.g ActionHandlerRegistry). Refactor existing classes accordingly - Clearly distinguish between action and operation and make operation a subtype of action - Rework ActionHandler API to enable cleaner and easier implementations - Rework OperationHandler API to enable cleaner and easier implementations - Actions can now be derived from the HandlerBinding and do not have to be registered separately - Introduce subtypes for create operations and handler - Rework client operation retrieval ( now uses RequestContextActions) - Introduce common generic API for commandPalette, toolPalette and context menu retrieval (ContextActionsProvider API) Co-authored-by: Philip Langer <[email protected]>
* Fix BasicActionHandler constructor The derive...() method was not used * Switch to stable update site for ELK
The purpose of the issue template is to indicate that issues should be created in the GLSP umbrella project and not in the subcomponents. eclipse-glsp/glsp#13
* Add unit tests for glsp.graph and jenkins config Resolves eclipse-glsp/glsp#16
…clipse-glsp#51) * Add custom action for sending messages from the server to the client - Provide new ServerMessageAction to handle messages - Remove 'details' from ServerStatusAction as not displayed in widget - Fixes eclipse-glsp/glsp/issues/48 Co-authored-by: Philip Langer <[email protected]>
…ipse-glsp#53) * DefaultToolPaletteItemProvider should provide a consistent order eclipse-glsp/glsp#51
…-glsp#54) * Add base types for auto-complete eclipse-glsp/glsp#56 * Add generic edit validation support for validating input while editing eclipse-glsp/glsp#56 * Introduce registry for easy context edit validator registration * Harmonize label validation with edit validation
…pse-glsp#58) This seems to happen with Theia clients. So we need to account for that in the server API in NavigationTarget. eclipse-glsp/glsp#69
eclipse-glsp#63) * eclipse-glsp#82 Properly dispose sockets after client connection close Also improve the log output for the DefaultGlspServerLaucher class. Resolves eclipse-glsp/glsp/issues/82 * Address review comments
…ationHandler The default implementation just returns the location provided by the operation. Subclasses can overwrite this behavior. (e.g. for grind snapping). Part of eclipse-glsp/glsp/issues/42
- Add Readonly support to ModelState and disable operation execution when in readonly mode. - Introduce SetEditMode action - Refactor ModelState/GraphicalModelState - Rename FilebaseModelfactory to JsonFileModelFactory and remove default binding - Improve parsing methods for ClientOptions (proper handling of null args) part of eclipse-glsp/glsp/issues/87
… dispatcher (eclipse-glsp#66) * eclipse-glsp#21: Align action processor more with client-side action dispatcher - Action processor should invoke ALL registered action handlers - Each response by an action handler should be processed - Introduce client action handler that sends actions to client Note: This change does not adapt the operation handlers which execute operations and do not return any actions as of now. Fixes eclipse-glsp/glsp#21 Signed-off-by: Martin Fleck <[email protected]> * eclipse-glsp#21: Incorporate feedback - Fix wrong logger - Add missing client actions - Add client-side actions that could be sent from server -- NavigateToTarget action - Remove actions that are neither used on the server nor on the client -- CollapseExpandAction -- CollapseExpandAllAction -- OpenAction -- RequestExportSvgAction Signed-off-by: Martin Fleck <[email protected]> * eclipse-glsp#21: Avoid registering actions that are automatically registered anyway - DIActionRegistry already considers handled actions and operations -- Remove default action binding altogether -- Only handled actions are part of the action registry - Add missing trigger actions and SetBounds action to client action set Signed-off-by: Martin Fleck <[email protected]>
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
tortmayr
requested changes
Oct 7, 2024
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/utils/CollaborationUtil.java
Show resolved
Hide resolved
...rver/src/org/eclipse/glsp/server/internal/gmodel/commandstack/GModelCommandStackFactory.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/CommandStackFactory.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/CommandStackManager.java
Show resolved
Hide resolved
.../org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/DefaultCommandStackManager.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server.emf/src/org/eclipse/glsp/server/emf/EMFModelStateImpl.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server.emf/src/org/eclipse/glsp/server/emf/EMFModelState.java
Outdated
Show resolved
Hide resolved
...ipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ModelSubmissionHandler.java
Outdated
Show resolved
Hide resolved
...glsp.server/src/org/eclipse/glsp/server/gmodel/AbstractGModelCreateNodeOperationHandler.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/Action.java
Outdated
Show resolved
Hide resolved
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after the inital `SetModelAction` - Change visibility of private members to protected for better extensibility - Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
Update type hints configuration for workflow example to make fork and join nodes not resizable => we have test cases for both resizable and non-resizable elements in the diagram
- Extract thread creation and initialization out of constructor Contributed on behalf of Axon Ivy AG
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
MatthiasHofstaetter
force-pushed
the
collabAdvanced
branch
from
1ea9aca to
6441a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Follow-ups
Changelog