Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some modifications from a fork #389

Closed
benjaminrancourt opened this issue Sep 4, 2020 · 2 comments · Fixed by #463
Closed

Some modifications from a fork #389

benjaminrancourt opened this issue Sep 4, 2020 · 2 comments · Fixed by #463
Assignees
@onderceylan
Labels
feature request New feature or request released

Comments

@benjaminrancourt
Copy link

Hi Önder Ceylan,

Thank you for your generator, it was really useful for my latest projects. :)

I made some changes to your code for my use case inside my fork. One of the modification was to generate MS Tiles icons (like #309)

Would you want me to make a pull request against your repository for the changes you want?

Or, feel free to copy and paste or even adapt my modifications. ;)
@benjaminrancourt benjaminrancourt added the feature request New feature or request label Sep 4, 2020
@onderceylan
Copy link
Collaborator

Hey @ranb2002, thank you for your feedback and for the improvement ideas you shared! Would you like to contribute with the MS Tiles icons change of yours for starters? That's a very good candidate imho as it's an active feature request as you referred.

onderceylan added a commit that referenced this issue Nov 30, 2020
@onderceylan
feat(main): add optional windows mstile icon generation
ca58190 
Add mstile icon generation for Windows platform, targeting web apps pinned to the system.

fix #309 fix #389
@onderceylan onderceylan self-assigned this Nov 30, 2020
@onderceylan onderceylan mentioned this issue Nov 30, 2020
Merged
onderceylan added a commit that referenced this issue Nov 30, 2020
@onderceylan
feat(main): add optional windows mstile icon generation
91ae0a9 
Add mstile icon generation for Windows platform, targeting web apps pinned to the system.

fix #309 fix #389
onderceylan pushed a commit that referenced this issue Nov 30, 2020
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
56fd10d 
# [4.0.0](v3.2.3...v4.0.0) (2020-11-30)

### Bug Fixes

* **main:** add --no-sandbox option to optionally disable sandboxing on linux ([79444d2](79444d2))

### Features

* **main:** add iPhone 12 specs to fallback data ([e1f8a27](e1f8a27)), closes [#454](#454)
* **main:** add optional windows mstile icon generation ([91ae0a9](91ae0a9)), closes [#309](#309) [#389](#389)
* **main:** reduce apple icons to a single file size ([c8f1321](c8f1321)), closes [#433](#433)

### BREAKING CHANGES

* **main:** Generated Apple touch icons is reduced to one icon. The icon file type is set to
PNG as default type, rather than a JPEG type.
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
2 participants
@onderceylan @benjaminrancourt