iPhone 12 Pro sizes #454
Assignees
Labels
Comments
|
Hey @samselikoff! Thanks for opening the issue. Unfortunately, Apple did not update their dev site in a timely manner yet, which is the data source where scraping happens. Considering Apple's delay on updating it's own site, I now think it might be better to maintain this specs manually and ditch the scraping part. |
|
Gotcha. In the meantime is there an escape hatch , a way to add individual devices?
… On Nov 18, 2020, at 1:46 AM, Önder Ceylan ***@***.***> wrote:
Hey @samselikoff! Thanks for opening the issue. Unfortunately, Apple did not update their dev site in a timely manner yet, which is the data source where scraping happens.
Considering Apple's delay on updating it's own site, I now think it might be better to maintain this specs manually and ditch the scraping part.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
onderceylan
added a commit
that referenced
this issue
Nov 30, 2020
Add iPhone 12 specs to fallback data for offline use. fix #454
onderceylan
added a commit
that referenced
this issue
Nov 30, 2020
Add iPhone 12 specs to fallback data for offline use. fix #454
onderceylan
pushed a commit
that referenced
this issue
Nov 30, 2020
# [4.0.0](v3.2.3...v4.0.0) (2020-11-30) ### Bug Fixes * **main:** add --no-sandbox option to optionally disable sandboxing on linux ([79444d2](79444d2)) ### Features * **main:** add iPhone 12 specs to fallback data ([e1f8a27](e1f8a27)), closes [#454](#454) * **main:** add optional windows mstile icon generation ([91ae0a9](91ae0a9)), closes [#309](#309) [#389](#389) * **main:** reduce apple icons to a single file size ([c8f1321](c8f1321)), closes [#433](#433) ### BREAKING CHANGES * **main:** Generated Apple touch icons is reduced to one icon. The icon file type is set to PNG as default type, rather than a JPEG type.
|
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome - nice work man!! Thank you!
… On Nov 30, 2020, at 4:42 PM, Önder Ceylan ***@***.***> wrote:
🎉 This issue has been resolved in version 4.0.0 🎉
The release is available on:
npm package ***@***.*** dist-tag)
GitHub release
Your semantic-release bot 📦🚀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thanks for contributing @samselikoff! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't think iPhone 12 Pro has a corresponding link generated. I believe the resolution is 2,532 x 1,170.
I was under the impression the scraping tool would have caught this but is there a static place in this repo that requires it?
Thanks for this amazing tool!
The text was updated successfully, but these errors were encountered: