iOS icon & index.html revise #433
Assignees
Labels
Comments
|
By the way, thank you for making this lovely helper. I really like it. :) |
|
Hi @Wasenshi123, thanks for your feedback and opening this improvement item! Your proposition makes sense, I'm going to reduce it to only one version. Btw, feel free to open a PR about it and link it to this issue. |
onderceylan
added a commit
that referenced
this issue
Nov 30, 2020
A single icon file should be sufficient to use for most use cases on Apple devices according to Lighthouse and Webhint docs. BREAKING CHANGE: Generated Apple touch icons is reduced to one icon. The icon file type is set to PNG as default type, rather than a JPEG type. fix #433
onderceylan
added a commit
that referenced
this issue
Nov 30, 2020
A single icon file should be sufficient to use for most use cases on Apple devices according to Lighthouse and Webhint docs. BREAKING CHANGE: Generated Apple touch icons is reduced to one icon. The icon file type is set to PNG as default type, rather than a JPEG type. fix #433
onderceylan
pushed a commit
that referenced
this issue
Nov 30, 2020
# [4.0.0](v3.2.3...v4.0.0) (2020-11-30) ### Bug Fixes * **main:** add --no-sandbox option to optionally disable sandboxing on linux ([79444d2](79444d2)) ### Features * **main:** add iPhone 12 specs to fallback data ([e1f8a27](e1f8a27)), closes [#454](#454) * **main:** add optional windows mstile icon generation ([91ae0a9](91ae0a9)), closes [#309](#309) [#389](#389) * **main:** reduce apple icons to a single file size ([c8f1321](c8f1321)), closes [#433](#433) ### BREAKING CHANGES * **main:** Generated Apple touch icons is reduced to one icon. The icon file type is set to PNG as default type, rather than a JPEG type.
|
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
about generating iOS icon and changing index.html file, regarding to
apple-touch-iconAccording to this guideline that I have found:
I propose to change the way this generator modify index.html to include only the default
<link rel="apple-touch-icon" href="...">linked to 180x180 image.Or add an option for this.
Additional info:
I have tested this on iOS 13.7, iPhone X, which should use 180x180 (@3x), but the result is, the icon is blurry.
Then I found out that this is because the iOS/Safari selectively uses a 120x120 (@2x) version instead of 180x180, and this is according to their rule.
But when I modify index.html to include only the default one linked to 180x180 like suggest above, the icon is clear, and the 180x180 (@3x) version is used correctly.
The text was updated successfully, but these errors were encountered: