chore(build): Release using github token rather than ssh auth. #30
Conversation
|
I should have asked this question when I first saw this stuff floating around. I typically also use GH token. |
.travis.yml
Outdated
| @@ -14,5 +14,5 @@ script: yarn run validate && yarn run build | |||
| deploy: | |||
| provider: script | |||
| skip_cleanup: true | |||
| script: bash _scripts/deploy.sh | |||
| script: npx semantic-release | |||
There was a problem hiding this comment.
Is it possible to leave off this line? Otherwise you're basically implemented #17. And in which case it should be:
npx travis-deploy-once "npx semantic-release"
There was a problem hiding this comment.
I'll probably have to delete/comment out the entire block so travis won't error in the meantime, but yeah I can do that.
There was a problem hiding this comment.
Yeah if you feel confident that this approach works then I can do the deploy part in implementing #17
|
Glad we're going the GH token route. More standard and seemingly much simpler. |
|
Whoops, wrong button |
|
Basically the reasoning behind originally wanting the ssh auth was that it gave finer-grained access control over the token.... But obviously it's been a headache to get setup, and even then it didn't work, so yeah. I'm hoping this way is better. |
|
Well it's likely that we're going to want to have a number of these types of repo so the special Travis user will make adding new repos/packages a lot easier |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Giving up on trying to make semantic release work with ssh auth, while it's documented the command continually fails because there's a check to use the token that it can't progress past.
I'm going to also clean up travis to get rid of all the superfluous environment variables.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: