Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Release using github token rather than ssh auth. #30

Merged
merged 2 commits into from
Apr 19, 2018
Merged

chore(build): Release using github token rather than ssh auth. #30

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4075309
Release using github token rather than ssh auth.
dtardoin-eb Apr 19, 2018
d0468e1
deleting deploy block to not implement #17
dtardoin-eb Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ script: yarn run validate && yarn run build
deploy:
provider: script
skip_cleanup: true
script: bash _scripts/deploy.sh
script: npx semantic-release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to leave off this line? Otherwise you're basically implemented #17. And in which case it should be:

npx travis-deploy-once "npx semantic-release"

per: https://github.com/semantic-release/semantic-release/blob/caribou/docs/recipes/travis.md#multiple-node-jobs-configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably have to delete/comment out the entire block so travis won't error in the meantime, but yeah I can do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if you feel confident that this approach works then I can do the deploy part in implementing #17


21 changes: 0 additions & 21 deletions _scripts/deploy.sh
View file
Open in desktop

This file was deleted.