[pigeon] Adds annotation options to omit shared classes used in Event Channels #8566
+200
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartmorgan ready for review |
stuartmorgan
approved these changes
Feb 6, 2025
packages/pigeon/pigeons/event_channel_without_classes_tests.dart
Outdated
Show resolved
Hide resolved
| if (containsEventChannelApi) { | ||
| result.add(Error( | ||
| message: | ||
| 'Event Channel methods must all be included in a single EventChannelApi', |
There was a problem hiding this comment.
Do we have an issue tracking this? It's definitely low priority, but it's an unintuitive restriction.
There was a problem hiding this comment.
I can fix it in this pr, it's not super complex. The main issue is that naming collisions aren't managed properly, since all of the methods end up top level when generated.
There was a problem hiding this comment.
It doesn't need to be in this PR, just seemed worth filing so we had a tracker.
There was a problem hiding this comment.
filed flutter/flutter#162828
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2025
…d in Event Channels (flutter/packages#8566)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2025
flutter/packages@e6ce02c...625023a 2025-02-07 [email protected] [camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests (flutter/packages#8363) 2025-02-06 [email protected] [pigeon] Adds annotation options to omit shared classes used in Event Channels (flutter/packages#8566) 2025-02-06 [email protected] [quick_actions] Update Android Pigeon version (flutter/packages#8580) 2025-02-05 [email protected] [ci] Move Wasm test shards out of bringup. (flutter/packages#8572) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#161291
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).