[quick_actions] Update Android Pigeon version #8580
Merged
+275
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quick_actions_android` was still using a very old version of Pigeon; this updates to the current version. The changes are minimal, but this avoids inconsistency with other plugins (e.g., `setup` vs `setUp`), and potential issues with forcing old versions of transitive dependencies shared with `pigeon`.
stuartmorgan
commented
Feb 6, 2025
| @@ -30,7 +29,7 @@ | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| final class QuickActions implements AndroidQuickActionsApi { | |||
| protected static final String EXTRA_ACTION = "some unique action key"; | |||
| static final String EXTRA_ACTION = "some unique action key"; | |||
There was a problem hiding this comment.
This was flagged as using protected in a final class. I'm not actually sure how this was compiling before though; QuickActionsPlugin uses this, but isn't a subclass of QuickActions.
| // noop | ||
| }); | ||
| ShortcutManagerCompat.reportShortcutUsed(context, shortcutId); | ||
| if (shortcutId != null) { |
There was a problem hiding this comment.
This check was added because there was a warning about shortcutId being potentially null in the call to launchAction. Probably this never actually happens, but if it does, better to do nothing than to crash.
tarrinneal
approved these changes
Feb 6, 2025
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2025
flutter/packages@e6ce02c...625023a 2025-02-07 [email protected] [camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests (flutter/packages#8363) 2025-02-06 [email protected] [pigeon] Adds annotation options to omit shared classes used in Event Channels (flutter/packages#8566) 2025-02-06 [email protected] [quick_actions] Update Android Pigeon version (flutter/packages#8580) 2025-02-05 [email protected] [ci] Move Wasm test shards out of bringup. (flutter/packages#8572) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick_actions_androidwas still using a very old version of Pigeon; this updates to the current version. The changes are minimal, but this avoids inconsistency with other plugins (e.g.,setupvssetUp), and potential issues with forcing old versions of transitive dependencies shared withpigeon.Also makes some minor code improvements on the Java side that were flagged by the IDE's linter.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).