Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move Wasm test shards out of bringup. #8572

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ditman
Copy link
Member

@ditman ditman commented Feb 5, 2025

This PR moves the new Wasm shards out of bringup, so they become part of the normal testing flow.

Here's some information about the last ~90 builds in the staging builder:

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan February 5, 2025 19:48
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
Copy link
Contributor

auto-submit bot commented Feb 5, 2025

autosubmit label was removed for flutter/packages/8572, because - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member Author

ditman commented Feb 5, 2025

The failing test is unrelated to this change. Restarting it, and reapplying the autosubmit label.

(In fact, the wasm shards have all already passed!)

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
Copy link
Contributor

auto-submit bot commented Feb 5, 2025

autosubmit label was removed for flutter/packages/8572, because - The status or check suite Linux_android custom_package_tests master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member Author

ditman commented Feb 5, 2025

Running Linux_android custom_package_tests master locally to see if it's a flake or not (package: web_benchmarks)

@ditman
Copy link
Member Author

ditman commented Feb 5, 2025

Flaky, flaky!

------------------------------------------------------------
Run overview:
  packages/web_benchmarks - ran

Ran for 1 package(s)


No issues found!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot merged commit 97b6074 into flutter:main Feb 5, 2025
83 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 7, 2025
flutter/packages@e6ce02c...625023a

2025-02-07 [email protected] [camera] Remove OCMock from
AvailableCamerasTests, CameraOrientationTests and
ThreadSafeEventChannelTests (flutter/packages#8363)
2025-02-06 [email protected] [pigeon] Adds annotation options to omit
shared classes used in Event Channels (flutter/packages#8566)
2025-02-06 [email protected] [quick_actions] Update Android Pigeon
version (flutter/packages#8580)
2025-02-05 [email protected] [ci] Move Wasm test shards out of bringup.
(flutter/packages#8572)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[integration_test] Flutter Web WASM support
2 participants