-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Move Wasm test shards out of bringup. #8572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
autosubmit label was removed for flutter/packages/8572, because - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
The failing test is unrelated to this change. Restarting it, and reapplying the (In fact, the wasm shards have all already passed!) |
autosubmit label was removed for flutter/packages/8572, because - The status or check suite Linux_android custom_package_tests master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Running |
Flaky, flaky!
|
flutter/packages@e6ce02c...625023a 2025-02-07 [email protected] [camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests (flutter/packages#8363) 2025-02-06 [email protected] [pigeon] Adds annotation options to omit shared classes used in Event Channels (flutter/packages#8566) 2025-02-06 [email protected] [quick_actions] Update Android Pigeon version (flutter/packages#8580) 2025-02-05 [email protected] [ci] Move Wasm test shards out of bringup. (flutter/packages#8572) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR moves the new Wasm shards out of bringup, so they become part of the normal testing flow.
Here's some information about the last ~90 builds in the staging builder:
Issues
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.