Feature: Fullview Flyte Deck modal #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 65.91% 65.91%
=======================================
Files 489 490 +1
Lines 11919 11950 +31
Branches 2198 2202 +4
=======================================
+ Hits 7856 7877 +21
- Misses 4063 4073 +10
|
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
FrankFlitton
changed the title
jsonporter
approved these changes
May 19, 2023
wild-endeavor
added a commit
to flyteorg/flyte
that referenced
this pull request
May 22, 2023
Signed-off-by: Yee Hing Tong <[email protected]> ### Admin - v1.1.100 * Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549 * Fix flaky test by @eapolinario in flyteorg/flyteadmin#563 * Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553 * Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564 * Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566 ### Console - v1.8.2 * Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757 * fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758 * fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759 * Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760 * chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761 * Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764 ### Propeller - v1.1.90 * Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a button to allow Flyte Deck modal expands full screen. Also, added escape to close listener for the modal.
Type
Are all requirements met?
Complete description
Added a button to toggle fullscreen. Passed a conditional CSS class to the
MUI Papercomponent to change the size. The full view size accounts for the small view port constraint for tablets and touch screens with dynamic viewport sizing.Close on
Esckey is achieved with auseEffectdocument listener pattern.Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#2774
flyteorg/flyte#3701
Follow-up issue
NA