fix: render correct date in job listing web view #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Dec 4, 2024
| @@ -187,7 +187,7 @@ | |||
| {{ _("Closes On") if status == "Open" else _("Closed On") }} | |||
| </div> | |||
| <div class="font-weight-bold"> | |||
| {{ frappe.format_date(closes_on if status == "Open" else closed_on, "d MMM, YYYY") }} | |||
| {{ frappe.utils.formatdate(closes_on if status == "Open" else closed_on, "d MMM, YYYY") }} | |||
There was a problem hiding this comment.
Okay weird
So
frappe.utils.format_date also works fine
because internally, formatdate = format_date in the framework:
While frappe.format_date points to a different function altogether which seems to be buggy (framework):
ruchamahabal
reviewed
Dec 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 74bc96a)
|
@AyshaHakeem we will also have to replace the function call in Edit: Also, if interested, dig in deeper on why |
ruchamahabal
added a commit
that referenced
this pull request
Dec 4, 2024
) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Aysha <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# [15.36.0](v15.35.3...v15.36.0) (2024-12-09) ### Bug Fixes * Apply system precision value while validating leave balance (backport [#2482](#2482)) ([#2489](#2489)) ([4d2c5f6](4d2c5f6)) * prompt user to select company for shift & attendance report creation (backport [#2461](#2461)) ([#2475](#2475)) ([2bfd0b0](2bfd0b0)) * render correct date in job listing web view (backport [#2464](#2464)) ([#2478](#2478)) ([4e2b6ea](4e2b6ea)) * **Salary Assignment:** skip warning for missing opening entries in the absence of tax components (backport [#2472](#2472)) ([#2477](#2477)) ([531d16b](531d16b)) ### Features * add Absent Days column to salary register (backport [#2485](#2485)) ([#2493](#2493)) ([67077ee](67077ee))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the format_date function with frappe.utils.format_date to resolve an issue where year-end dates, such as 12-31-2024, were incorrectly rendered with the wrong year (31 Dec, 2025) in the web view. Using frappe.utils.format_date ensures accurate rendering.
Date Stored:
Date Rendered:
Before (incorrect year):
After:
