Add/link control #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create individual blocks as appropriate (WordPress#65144) * Drag and Drop: When dragging a mix of video, audio, and image blocks, create individual blocks as appropriate * Consolidate into the fallback transform for the File block Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: kevin940726 <[email protected]> Co-authored-by: swissspidy <[email protected]>
* Disallow setting grid block rows/columns to zero * Prevent issues with grid block column/row count by ensuring a proper minimum Co-authored-by: talldan <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: mirka <[email protected]>
* feat: Adds the block controls for uploading image. * feat: Adds the size based placeholder logic. * fix: The layout design for small images and adds grid support. * refactor: Remove resize observer and add lockURLControls support. * refactor: Make use of the existing MediaReplaceFlow component. * fix: The mediaPlaceholder location after merge. * fix: The initial flash in small size. * feat: Removes the redundant css and redefine the placeholder logic. * fix: Adressed the PR feedbacks. * fix: Removes the effective width logic and moves observer inside of placeholder. * fix: The e2e test failures * Update packages/block-library/src/image/edit.js Co-authored-by: Aki Hamano <[email protected]> --------- Co-authored-by: vipul0425 <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
co-authored-by: kevin940726 <[email protected]>Co-authored-by: aaronrobertshaw <[email protected]>Co-authored-by: andrewserong <[email protected]>Co-authored-by: ramonjd <[email protected]> * Fix resizing to max width in classic themes * Fix padding and max-width * Reverse the condition * Try ignoring if layout doesn't exist
Co-authored-by: t-hamano <[email protected]> Co-authored-by: kevin940726 <[email protected]> Co-authored-by: ramonjd <[email protected]>
…into add/link-control
* DatePicker: better hover/focus styles * CHANGELOG * Use after pseudo-element to avoid conflict with calendar event dot * Make event dots compatible with high contrast mode * Apply box sizing utility * Use themed colors * Use translate to prevent event dot from jumping --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: t-hamano <[email protected]>
…Press#65231) * Navigator Screen: warn if path doesn't follow the expected scheme * Add test * CHANGELOG --- Co-authored-by: ciampo <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]>
…ordPress#65062) * Inherit post type from template slug * Move map outside of `useSelect` Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: artemiomorales <[email protected]> Co-authored-by: cbravobernal <[email protected]>
Co-authored-by: AKSHAT2802 <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: afercia <[email protected]>
- Rename the "interactivity" webpack build to "script modules". - Output script-modules builds to `build-module` folder (adjacent to the `build` folder currently used for scripts). - Add `wpScriptModulesExports` package.json field to packages with script modules and use it for script module builds. This follows the same basic syntax as [package.json `exports` fields](https://nodejs.org/api/packages.html#exports). Multiple module entrypoints can be exposed per package. However, it remains a custom field, so it is clear that these entrypoints are not intended for general consumption. In the future, module-only packages (interactivity, interactivity-router) can switch to using exports directly and likely add `type: module`. - There are some difficulties with webpack recognizing `wpScriptModulesExports` directly, so packages are inspected programmatically in order to generate webpack script modules entrypoints. - Adjust script module registration accordingly to find the generated script modules. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: t-hamano <[email protected]>
…into add/link-control
|
Size Change: +4.24 kB (+0.24%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 11, 2024
| id: 'slug', | ||
| getValue: ( { item } ) => item.slug, | ||
| render: SlugView, | ||
| Edit: SlugEdit, |
There was a problem hiding this comment.
Any reason for exporting SlugView and SlugEdit separately, instead of exporting the whole field from the other package?
Ultimately though (later), I feel like we might not need to export the fields directly we could just have a selector to fetch the fields per post type (like we do for actions)
There was a problem hiding this comment.
I see your point and I agree with you! For now, I would orient to follow this approach.
Ultimately though (later), I feel like we might not need to export the fields directly we could just have a selector to fetch the fields per post type (like we do for actions)
It makes sense!
There was a problem hiding this comment.
I see your point and I agree with you! For now, I would orient to follow this approach.
👍
Co-authored-by: gigitux <[email protected]> Co-authored-by: youknowriad <[email protected]>
* Refactor utils and switch Tabs indicator animation to `transform`. * docs tweak * Update packages/components/src/tabs/styles.ts Co-authored-by: Marco Ciampini <[email protected]> * Add RTL support. * Addressed @ciampo's comments. * Correct for antialiasing rounding. * Make antialiasing adjustment optional. * Use larger base value and revert antialiasing adjustment code. * DRY RTL * Remove RTL story (redundant since Storybook has a dynamic setting to test RTL). * Fix bug. * Fix bug (for real this time). * Add changelog entry. * De-cleverfy code. * Sync useResizeObserver with WordPress#64943 and make useTrackElementOffsetRect resilient. * Deduplicate utility and clean up. * DRY antialiasing factor. * Changelogs. --------- Co-authored-by: DaniGuardiola <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]>
Co-authored-by: jeryj <[email protected]> Co-authored-by: getdave <[email protected]>
* Remove colons from control labels in docs * Remove label colon from Archives block * Remove label colon in Latest Posts block * Fix label in Legacy Widget block * Shorten to "Legacy widget" and update test Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: DaniGuardiola <[email protected]> Co-authored-by: jasmussen <[email protected]>
…Press#65236) co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]>
* Try block inspector controls spacing normalization * Decrease specificity * Add changelog * Grid block: Fix when experimental grid interactivity * Remove adjustment for bottom padding * Revert "Add changelog" This reverts commit 7939750. * Remove unnecessary margin on Layout hook toggle (WordPress#65133) Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: tyxla <[email protected]>
…block (WordPress#64971) Co-authored-by: hbhalodia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: AKSHAT2802 <[email protected]> Co-authored-by: Nyiriland <[email protected]>
…prefix (WordPress#65260) * Plugin: Remove 'function_exists' checks for methods with 'gutenberg' prefix * Move code into the correct compat file Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]>
…s#64828) * update stylelint deps to latest and convert deprecated rules to @Stylistic * prevent extra rules being added * fix rule name change * fix scss overwrite bug * fix stylelint disables/enables * migrate stylistic styles to separate configs to make it easy to opt out for consumers * fix: switch stylistic config dep for plugin * use require.resolve for stylelint recommended config * fix stylelint unit tests * fix global mocks for node env * use correct configs for tests * add type checking for configs * convert tests to esm * remove unnecessary await * fix stylelint tests * remove experimental-vm-modules flag * revert jest globals changes * move utils to folder * update readme * update changelogs --------- Co-authored-by: Greg Ziółkowski <[email protected]> Unlinked contributors: 75th, vicobot-0815. Co-authored-by: mikeybinns <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: jacobcassidy <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: paulschreiber <[email protected]> Co-authored-by: stein2nd <[email protected]>
* Show top level sections in List View * Recompute enabled clientIds when editorMode changes * Revert initial changes * Avoid special conditional for Zoom Out mode
* Add __next40pxDefaultSize in button for editor 3 files * address feedback Co-authored-by: AKSHAT2802 <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]>
Co-authored-by: oandregal <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: Souptik2001 <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: SaxonF <[email protected]> Co-authored-by: jasmussen <[email protected]>
* Use iframe even with metaboxes * Split content view when metaboxes are open * Fix styling issues Co-authored-by: t-hamano <[email protected]> * Update e2e tests Co-authored-by: ellatrix <[email protected]> * Make metaboxes a details element in short viewports * Make metabox area resizable when viewport isn’t short * Tweak details element usage * Add max-height when resized by user * Hide metabox area if all metaboxes are hidden * Persist toggle and height state in user preferences * Wrap contents and rename things The added wrapping element was due to Safari clipping the drop-shadow when `overflow: auto` was on the component root. * Make visual editor stacking context when iframed with metaboxes * Omit meta box area when empty instead of hiding it * Fix meta boxes content appearing in front of UI * Use split views only when canvas is iframed * Don’t omit main meta box area unless all locations aren’t visible --------- Co-authored-by: t-hamano <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: torounit <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: arnaudbroes <[email protected]>
* Update minimum required version in PHP. * Use a constant. * Test plugin meta data and constant match. * Set constant incorrectly to demonstrate failing tests. * Use regex to extract the constant. * Match the version in the constant and plugin meta. Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: Mamaduka <[email protected]>
… is available (WordPress#65300) * DimensionsPanel: Apply 40px default size to UI when no spacing preset is available * Revert unnecessary change Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jameskoster <[email protected]>
…ordPress#65337) Co-authored-by: Mamaduka <[email protected]>
…dPress#65060) co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: cuemarie <[email protected]>
Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
… styles into Background group (WordPress#65304) Expose background styles in the top level global styles navigation menu. Background is now underneath color. Refactor background image controls and their styles into a dedicated component. This is in preparation for adding colors and other background controls later. Co-authored-by: amitraj2203 <[email protected]> Co-authored-by: mtias <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: jameskoster <[email protected]>
Enables filtering the query loop result by post format. To allow querying a given post format, a new parameter, `format` is added to a new compatibility class called `Gutenberg_REST_Posts_Controller_6_7`, which extends the core class `WP_REST_Posts_Controller`. Query loop block: - Adds a new parameter, `format`, to the `query` attribute in block.json. - Adds a new `FormatControls` that uses a list of supported post formats inside a `FormTokenField`. This control is placed in the `Filters` panel in the block settings sidebar. - Adds a new utility function `gutenberg_add_format_query_vars_to_query_loop_block` to ensure that the Query loop block can pass the new `format` argument correctly to `WP_Query`. This function is hooked into `query_loop_block_query_vars`. Post Template block: The new `format` parameter is passed from the query loop block to the post template block as part of the `query` attribute. --------- Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: dmsnell <[email protected]> Co-authored-by: TimothyBJacobs <[email protected]> Co-authored-by: nickbohle <[email protected]> Co-authored-by: SergeyBiryukov <[email protected]> Co-authored-by: justintadlock <[email protected]>
Co-authored-by: jeryj <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: MaggieCabrera <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: ockham <[email protected]> Co-authored-by: gziolo <[email protected]>
…ordPress#65219) * Add JSDoc block for getSectionRootClientId in block editor * Apply suggestions from code review Co-authored-by: Dave Smith <[email protected]> --------- Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: mirka <[email protected]> Co-authored-by: DaniGuardiola <[email protected]> Co-authored-by: ciampo <[email protected]>
… 2] (WordPress#65258) * Fix font library modal fonts to use 40px default button size * Fix install font button to use default 40px size * Fix the installed fonts button size to use 40px default * Fix upload font button size to use 40px default size * Fix add the default button 40px size for randomize color pallete button * Fix edit site style revision button to use 40px default size * Fix edit site shadow components buttons to use default 40px size * Fix the style for the button height on the font library modal * Add !important to override the button size for 40px Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]>
* Convert EmbedPreview component to functional component * Update interactive condition and move call inline versus within useEffect Unlinked contributors: louwie17. Co-authored-by: ntsekouras <[email protected]> Co-authored-by: kevin940726 <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jameskoster <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jasmussen <[email protected]>
…I Reference (WordPress#65375) Co-authored-by: t-hamano <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
…ess#65321) Bumps the react-native group with 2 updates in the / directory: [actions/setup-java](https://github.com/actions/setup-java) and [gradle/actions](https://github.com/gradle/actions). Updates `actions/setup-java` from 4.2.2 to 4.3.0 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@6a0805f...2dfa201) Updates `gradle/actions` from 4.0.0 to 4.1.0 - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@af1da67...d156388) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor dependency-group: react-native - dependency-name: gradle/actions dependency-type: direct:production update-type: version-update:semver-minor dependency-group: react-native ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: desrosj <[email protected]>
* Adds post type label to DocumentBar * Removes the post type icon from the DocumentBar * Try fixing one of the e2e tests * Remove IconType import and add typedef * Adds font-weight to heading and uses darker grey for constrast * Adjusts title overflow so it dosen't apply to post type label * Moves font weight to h1 * Try fixing more e2e tests * Fix another e2e * Add fix for mid screensizes when Back button is present * Hide post type label on small screen sizes --------- Co-authored-by: creativecoder <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: richtabor <[email protected]>
…anges from Core (WordPress#65259) Global Styles: Update REST controller override method: Update unit tests; Update class with Core's WP_REST_Global_Styles_Controller; Inherit WP_REST_Posts_Controller, make methods public et. al; Add 6.6+ post args to register post filter; Overwrite Core endpoints with $override when registering routes. --------- Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: spacedmonkey <[email protected]>
* BoxControl: Add lint rule for 40px size prop usage * Add to readme Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
… apply (WordPress#65384) Co-authored-by: andrewserong <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: annezazu <[email protected]>
* Add __next40pxDefaultSize for files in editor 3 * Address feedback * change font size to 13 px * Revert classic-theme.js changes as it will be a seperate PR and revert 13px size in style as it is default * Wrap copy button in InputControlSuffixWrapper Co-authored-by: AKSHAT2802 <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
…ordPress#65377) * Remove duplicate keyframe definition across packages * Deprecate edit-post__fade-in-animation, replace with animation__fade-in * Add animation__fade-out mixin
gigitux
added a commit
that referenced
this pull request
Sep 25, 2024
…ordPress#65289) Co-authored-by: gigitux <[email protected]> Co-authored-by: louwie17 <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast